third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp - Issue 2223223002: [ParseHTMLOnMainThread] Force plaintext synchronously on lookahead parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

Issue 2223223002: [ParseHTMLOnMainThread] Force plaintext synchronously on lookahead parser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add layout test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/parser/force-plaintext.html ('K') | « third_party/WebKit/LayoutTests/fast/parser/force-plaintext.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

index ed5d3592f20c47ae3ecd43aa377039fe2f1c5f45..20960c46ec5a2edb8915bdbc199616621f286455 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

@@ -573,7 +573,9 @@ void HTMLDocumentParser::forcePlaintextForTextDocument()

if (!m_haveBackgroundParser)

startBackgroundParser();

- postTaskToLookaheadParser(Asynchronous, &BackgroundHTMLParser::forcePlaintextForTextDocument, m_backgroundParser);

+ // This task should be synchronous, because otherwise synchronous

+ // tokenizing can happen before plaintext is forced.

kouhei (in TOK) 2016/08/09 23:54:02 Would you note this in CL description too?

+ postTaskToLookaheadParser(Synchronous, &BackgroundHTMLParser::forcePlaintextForTextDocument, m_backgroundParser);

} else

m_tokenizer->setState(HTMLTokenizer::PLAINTEXTState);

}

« third_party/WebKit/LayoutTests/fast/parser/force-plaintext.html ('K') | « third_party/WebKit/LayoutTests/fast/parser/force-plaintext.html ('k') | no next file » | no next file with comments »