Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2223213003: ChromeOS: Implement Accessibility Options screen of material design OOBE. (Closed)

Created:
4 years, 4 months ago by Alexander Alekseev
Modified:
4 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, dcheng, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Implement Accessibility Options screen of material design OOBE. This CL adds Accessibility Options screen to material design OOBE. BUG=604119 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d19df1cdee8e365d754eb8ba215db4e72a6b7463 Cr-Commit-Position: refs/heads/master@{#411267}

Patch Set 1 #

Total comments: 31

Patch Set 2 : Update after review. #

Total comments: 4

Patch Set 3 : Update after review. #

Patch Set 4 : Fix presubmit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -5 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 chunks +36 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/oobe_a11y_option.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/oobe_a11y_option.js View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_types.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.css View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.html View 1 2 chunks +65 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 2 3 5 chunks +52 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (18 generated)
Alexander Alekseev
This Cl doesn't have styles. I am going to correct styling later. Please review.
4 years, 4 months ago (2016-08-09 04:42:17 UTC) #3
michaelpg
mostly minor things https://codereview.chromium.org/2223213003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2223213003/diff/1/chrome/app/chromeos_strings.grdp#newcode1647 chrome/app/chromeos_strings.grdp:1647: <message name="IDS_ACCESIBILITY_SECTION_TITLE" desc="Title of accessibility options ...
4 years, 4 months ago (2016-08-09 20:33:09 UTC) #8
Alexander Alekseev
https://codereview.chromium.org/2223213003/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2223213003/diff/1/chrome/app/chromeos_strings.grdp#newcode1647 chrome/app/chromeos_strings.grdp:1647: <message name="IDS_ACCESIBILITY_SECTION_TITLE" desc="Title of accessibility options screen" meaning="A title ...
4 years, 4 months ago (2016-08-10 04:03:46 UTC) #9
michaelpg
lgtm https://codereview.chromium.org/2223213003/diff/1/chrome/browser/resources/chromeos/login/oobe_types.js File chrome/browser/resources/chromeos/login/oobe_types.js (right): https://codereview.chromium.org/2223213003/diff/1/chrome/browser/resources/chromeos/login/oobe_types.js#newcode44 chrome/browser/resources/chromeos/login/oobe_types.js:44: OobeTypes.A11yStatusSet; On 2016/08/10 04:03:46, Alexander Alekseev wrote: > ...
4 years, 4 months ago (2016-08-10 15:58:38 UTC) #14
Alexander Alekseev
https://codereview.chromium.org/2223213003/diff/20001/chrome/browser/resources/chromeos/login/oobe_a11y_option.js File chrome/browser/resources/chromeos/login/oobe_a11y_option.js (right): https://codereview.chromium.org/2223213003/diff/20001/chrome/browser/resources/chromeos/login/oobe_a11y_option.js#newcode10 chrome/browser/resources/chromeos/login/oobe_a11y_option.js:10: * If polymer-toggle-button is checked. On 2016/08/10 15:58:37, michaelpg ...
4 years, 4 months ago (2016-08-10 23:02:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223213003/40001
4 years, 4 months ago (2016-08-10 23:04:26 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/235479)
4 years, 4 months ago (2016-08-10 23:12:55 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223213003/60001
4 years, 4 months ago (2016-08-10 23:40:26 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/275687)
4 years, 4 months ago (2016-08-11 01:57:09 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223213003/60001
4 years, 4 months ago (2016-08-11 02:16:49 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-11 04:39:05 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 05:08:14 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d19df1cdee8e365d754eb8ba215db4e72a6b7463
Cr-Commit-Position: refs/heads/master@{#411267}

Powered by Google App Engine
This is Rietveld 408576698