Refactor fx_ge part 3

Move CFX_RenderDevice, CFX_FxgeDevice, and CFX_GraphStateData into their own files.

This is the third CL to separate fx_ge into classes, one per file.
All fx_ge.h includes had to be replaced with new includes
The method definitions for CFX_FxgeDevice were not moved to a single file.
These methods are defined in two folders different from fxge/ge, so they were left untouched for now.

Committed: https://pdfium.googlesource.com/pdfium/+/9ada2d83cbb629f286936ebc7a208a61164f873b

[npm, 2016-08-08 20:59:22]

Description was changed from

==========
Refactor fx_ge part 3
==========

to

==========
Move CFX_RenderDevice, CFX_FxgeDevice, and CFX_GraphStateData into their own
files.

This is the third CL to separate fx_ge into classes, one per file.
All fx_ge.h includes had to be replaced with new includes
The method definitions for CFX_FxgeDevice were not moved to a single file.
These methods are defined in two folders different from fxge/ge, so they were
left untouched for now.
==========

[npm, 2016-08-08 20:59:22]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-08 20:59:53]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 20:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:18:22]

Dry run: This issue passed the CQ dry run.

[npm, 2016-08-08 21:20:18]

PTAL
Sorry about the length, if I had seen how much these classes were being used I
would have split this into a couple of CLs. It is mostly include changes,
though.

[Lei Zhang, 2016-08-08 22:18:35]

On 2016/08/08 21:20:18, npm wrote:
> PTAL
> Sorry about the length, if I had seen how much these classes were being used I
> would have split this into a couple of CLs. It is mostly include changes,
> though.

If you move one class out at a time, it will probably be easier on your
reviewers.

[dsinclair, 2016-08-09 14:14:35]

The bulk of this is just include changes so I think it's fine for this Cl.

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_allstates.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_allstates.cpp:3: //
becore/fpdfapi/fpdf_page/cpdf_graphstate.h
Seems ... wrong.

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/incl...
File core/fpdfapi/fpdf_page/include/cpdf_path.h (right):

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/incl...
core/fpdfapi/fpdf_page/include/cpdf_path.h:12: #include
"core/fxge/include/cfx_fxgedevice.h"
Sort includes

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_de...
File core/fxge/win32/fx_win32_device.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_de...
core/fxge/win32/fx_win32_device.cpp:7: #include <algorithm>
This needs a #include "core/fxcrt/include/fx_system.h" before the _FX_OS_ below
othewise it won't be defined.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_di...
File core/fxge/win32/fx_win32_dib.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_di...
core/fxge/win32/fx_win32_dib.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_
== _FX_WIN64_DESKTOP_
This needs a fx_system.h include before this line.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_dw...
File core/fxge/win32/fx_win32_dwrite.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_dw...
core/fxge/win32/fx_win32_dwrite.cpp:8: 
fx_system.h

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_gd...
File core/fxge/win32/fx_win32_gdipext.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_gd...
core/fxge/win32/fx_win32_gdipext.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ ||
_FX_OS_ == _FX_WIN64_DESKTOP_
fx_system.h

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_pr...
File core/fxge/win32/fx_win32_print.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_pr...
core/fxge/win32/fx_win32_print.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ ||
_FX_OS_ == _FX_WIN64_DESKTOP_
fx_system.h

[npm, 2016-08-09 16:14:18]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 16:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-09 16:26:12]

TALP

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/cpdf...
File core/fpdfapi/fpdf_page/cpdf_allstates.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/cpdf...
core/fpdfapi/fpdf_page/cpdf_allstates.cpp:3: //
becore/fpdfapi/fpdf_page/cpdf_graphstate.h
On 2016/08/09 14:14:35, dsinclair wrote:
> Seems ... wrong.

Oops, my bad.

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/incl...
File core/fpdfapi/fpdf_page/include/cpdf_path.h (right):

https://codereview.chromium.org/2223213002/diff/1/core/fpdfapi/fpdf_page/incl...
core/fpdfapi/fpdf_page/include/cpdf_path.h:12: #include
"core/fxge/include/cfx_fxgedevice.h"
On 2016/08/09 14:14:35, dsinclair wrote:
> Sort includes

Done.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_de...
File core/fxge/win32/fx_win32_device.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_de...
core/fxge/win32/fx_win32_device.cpp:7: #include <algorithm>
On 2016/08/09 14:14:35, dsinclair wrote:
> This needs a #include "core/fxcrt/include/fx_system.h" before the _FX_OS_
below
> othewise it won't be defined.

Done.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_di...
File core/fxge/win32/fx_win32_dib.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_di...
core/fxge/win32/fx_win32_dib.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_
== _FX_WIN64_DESKTOP_
On 2016/08/09 14:14:35, dsinclair wrote:
> This needs a fx_system.h include before this line.

Done.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_dw...
File core/fxge/win32/fx_win32_dwrite.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_dw...
core/fxge/win32/fx_win32_dwrite.cpp:8: 
On 2016/08/09 14:14:35, dsinclair wrote:
> fx_system.h

Done.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_gd...
File core/fxge/win32/fx_win32_gdipext.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_gd...
core/fxge/win32/fx_win32_gdipext.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ ||
_FX_OS_ == _FX_WIN64_DESKTOP_
On 2016/08/09 14:14:35, dsinclair wrote:
> fx_system.h

Done.

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_pr...
File core/fxge/win32/fx_win32_print.cpp (right):

https://codereview.chromium.org/2223213002/diff/1/core/fxge/win32/fx_win32_pr...
core/fxge/win32/fx_win32_print.cpp:7: #if _FX_OS_ == _FX_WIN32_DESKTOP_ ||
_FX_OS_ == _FX_WIN64_DESKTOP_
On 2016/08/09 14:14:35, dsinclair wrote:
> fx_system.h

Done.

[commit-bot: I haz the power, 2016-08-09 16:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:33:01]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-10 13:20:57]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-10 13:20:58]

lgtm

[commit-bot: I haz the power, 2016-08-10 13:21:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 13:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 13:21:36]

Failed to apply patch for xfa/fxbarcode/oned/BC_OneDimWriter.h:
While running git apply --index -3 -p1;
  error: patch failed: xfa/fxbarcode/oned/BC_OneDimWriter.h:7
  Falling back to three-way merge...
  Applied patch to 'xfa/fxbarcode/oned/BC_OneDimWriter.h' with conflicts.
  U xfa/fxbarcode/oned/BC_OneDimWriter.h

Patch:       xfa/fxbarcode/oned/BC_OneDimWriter.h
Index: xfa/fxbarcode/oned/BC_OneDimWriter.h
diff --git a/xfa/fxbarcode/oned/BC_OneDimWriter.h
b/xfa/fxbarcode/oned/BC_OneDimWriter.h
index
10eccf9eeab21f31d7bee96367ad216f63915964..99ddd30a43b5b265452a5341e157d33b0f3dd9cc
100644
--- a/xfa/fxbarcode/oned/BC_OneDimWriter.h
+++ b/xfa/fxbarcode/oned/BC_OneDimWriter.h
@@ -7,7 +7,7 @@
 #ifndef XFA_FXBARCODE_ONED_BC_ONEDIMWRITER_H_
 #define XFA_FXBARCODE_ONED_BC_ONEDIMWRITER_H_
 
-#include "core/fxge/include/fx_ge.h"
+#include "core/fxge/include/cfx_renderdevice.h"
 #include "xfa/fxbarcode/BC_Writer.h"
 #include "xfa/fxbarcode/include/BC_Library.h"

[npm, 2016-08-10 14:29:36]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 14:49:24]

Dry run: This issue passed the CQ dry run.

[npm, 2016-08-10 14:51:06]

The CQ bit was checked by npm@chromium.org

[npm, 2016-08-10 14:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2223213002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-10 14:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 14:51:43]

Description was changed from

==========
Move CFX_RenderDevice, CFX_FxgeDevice, and CFX_GraphStateData into their own
files.

This is the third CL to separate fx_ge into classes, one per file.
All fx_ge.h includes had to be replaced with new includes
The method definitions for CFX_FxgeDevice were not moved to a single file.
These methods are defined in two folders different from fxge/ge, so they were
left untouched for now.
==========

to

==========
Move CFX_RenderDevice, CFX_FxgeDevice, and CFX_GraphStateData into their own
files.

This is the third CL to separate fx_ge into classes, one per file.
All fx_ge.h includes had to be replaced with new includes
The method definitions for CFX_FxgeDevice were not moved to a single file.
These methods are defined in two folders different from fxge/ge, so they were
left untouched for now.

Committed:
https://pdfium.googlesource.com/pdfium/+/9ada2d83cbb629f286936ebc7a208a61164f...
==========

[commit-bot: I haz the power, 2016-08-10 14:51:45]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/9ada2d83cbb629f286936ebc7a208a61164f...