Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/arc/bluetooth/arc_bluetooth_bridge.cc

Issue 2223203002: arc: bluetooth: Add/Remove BT observer only when ARC is ready (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nit in last patch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/bluetooth/arc_bluetooth_bridge.h ('k') | device/bluetooth/bluetooth_adapter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/bluetooth/arc_bluetooth_bridge.cc
diff --git a/components/arc/bluetooth/arc_bluetooth_bridge.cc b/components/arc/bluetooth/arc_bluetooth_bridge.cc
index dbc6747b662299696c5c1ebb56d1a9f069e3b04c..15eda47529850956a9947404bcc798e78001ada3 100644
--- a/components/arc/bluetooth/arc_bluetooth_bridge.cc
+++ b/components/arc/bluetooth/arc_bluetooth_bridge.cc
@@ -180,13 +180,12 @@ namespace arc {
ArcBluetoothBridge::ArcBluetoothBridge(ArcBridgeService* bridge_service)
: ArcService(bridge_service), binding_(this), weak_factory_(this) {
if (BluetoothAdapterFactory::IsBluetoothAdapterAvailable()) {
- VLOG(1) << "registering bluetooth adapter";
+ VLOG(1) << "Registering bluetooth adapter.";
BluetoothAdapterFactory::GetAdapter(base::Bind(
&ArcBluetoothBridge::OnAdapterInitialized, weak_factory_.GetWeakPtr()));
} else {
- VLOG(1) << "no bluetooth adapter available";
+ VLOG(1) << "No bluetooth adapter available.";
}
-
arc_bridge_service()->bluetooth()->AddObserver(this);
}
@@ -207,7 +206,14 @@ void ArcBluetoothBridge::OnAdapterInitialized(
// so our adapter uses BlueZ.
bluetooth_adapter_ =
static_cast<bluez::BluetoothAdapterBlueZ*>(adapter.get());
- bluetooth_adapter_->AddObserver(this);
+
+ // The ARC instance was ready before the Bluetooth adapter, hence we didn't
+ // register ourselves as an observer with it then. Since our adapter is
+ // ready, we should register it now.
+ if (!bluetooth_adapter_->HasObserver(this) &&
+ arc_bridge_service()->bluetooth()->instance()) {
+ bluetooth_adapter_->AddObserver(this);
+ }
}
void ArcBluetoothBridge::OnInstanceReady() {
@@ -218,7 +224,19 @@ void ArcBluetoothBridge::OnInstanceReady() {
<< "but no bluetooth instance found";
return;
}
+
bluetooth_instance->Init(binding_.CreateInterfacePtrAndBind());
+
+ // The Bluetooth adapter was ready before the ARC instance, hence we didn't
+ // register ourselves as an observer with it then. Since our instance is
+ // ready, we should register it now.
+ if (bluetooth_adapter_ && !bluetooth_adapter_->HasObserver(this))
+ bluetooth_adapter_->AddObserver(this);
+}
+
+void ArcBluetoothBridge::OnInstanceClosed() {
+ if (bluetooth_adapter_)
+ bluetooth_adapter_->RemoveObserver(this);
}
void ArcBluetoothBridge::AdapterPoweredChanged(BluetoothAdapter* adapter,
« no previous file with comments | « components/arc/bluetooth/arc_bluetooth_bridge.h ('k') | device/bluetooth/bluetooth_adapter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698