arc: bluetooth: Add/Remove BT observer only when ARC is ready

components/arc/bluetooth/arc_bluetooth_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/bluetooth/arc_bluetooth_bridge.h"
 
 #include <bluetooth/bluetooth.h>
 #include <fcntl.h>
 #include <stddef.h>
 #include <sys/socket.h>
@@ skipping 168 matching lines @@
 
 ArcBluetoothBridge::ArcBluetoothBridge(ArcBridgeService* bridge_service)
     : ArcService(bridge_service), binding_(this), weak_factory_(this) {
   if (BluetoothAdapterFactory::IsBluetoothAdapterAvailable()) {
     VLOG(1) << "registering bluetooth adapter";
     BluetoothAdapterFactory::GetAdapter(base::Bind(
         &ArcBluetoothBridge::OnAdapterInitialized, weak_factory_.GetWeakPtr()));
   } else {
     VLOG(1) << "no bluetooth adapter available";
   }
-
   arc_bridge_service()->bluetooth()->AddObserver(this);
 }
 
 ArcBluetoothBridge::~ArcBluetoothBridge() {
   DCHECK(CalledOnValidThread());
 
   arc_bridge_service()->bluetooth()->RemoveObserver(this);
 
   if (bluetooth_adapter_)
     bluetooth_adapter_->RemoveObserver(this);
 }
 
 void ArcBluetoothBridge::OnAdapterInitialized(
     scoped_refptr<BluetoothAdapter> adapter) {
   DCHECK(CalledOnValidThread());
 
   // We can downcast here because we are always running on Chrome OS, and
   // so our adapter uses BlueZ.
   bluetooth_adapter_ =
       static_cast<bluez::BluetoothAdapterBlueZ*>(adapter.get());
-  bluetooth_adapter_->AddObserver(this);
+
+  // Arc instance is ready before Bluetooth adapter.
+  // We should register ourself to bluetooth observer here.

[Luis Héctor Chávez, 2016/08/08 21:12:03]

nit: s/ourself/ourselves/. Same below.

[puthik_chromium, 2016/08/08 21:40:25]

Done.

+  if (!bluetooth_observer_flag_ &&
+      arc_bridge_service()->bluetooth()->instance()) {
+    bluetooth_observer_flag_ = true;
+    bluetooth_adapter_->AddObserver(this);
+  }
 }
 
 void ArcBluetoothBridge::OnInstanceReady() {
   mojom::BluetoothInstance* bluetooth_instance =
       arc_bridge_service()->bluetooth()->instance();
   if (!bluetooth_instance) {
     LOG(ERROR) << "OnBluetoothInstanceReady called, "
                << "but no bluetooth instance found";
     return;
   }
-  bluetooth_instance->Init(binding_.CreateInterfacePtrAndBind());

[rkc, 2016/08/08 21:16:15]

Where are we doing this now?

[puthik_chromium, 2016/08/08 21:40:25]

My error. Fixed

+
+  // Bluetooth adapter is ready before Arc instance.
+  // We should register ourself to bluetooth observer here.
+  if (!bluetooth_observer_flag_ && bluetooth_adapter_) {
+    bluetooth_observer_flag_ = true;
+    bluetooth_adapter_->AddObserver(this);
+  }
+}
+
+void ArcBluetoothBridge::OnInstanceClosed() {
+  if (bluetooth_observer_flag_ && bluetooth_adapter_)

[Luis Héctor Chávez, 2016/08/08 21:12:03]

If you remove the flag like rkc@ suggested, maybe do bluetooth_adapter_.reset()
here.

[rkc, 2016/08/08 21:16:15]

+1

[puthik_chromium, 2016/08/08 21:40:25]

I changed to code to hold make bluetooth_adapter_ a valid pointer all the time.
Or else we need to add null check for bluetooth_adapter_ to every function.

+    bluetooth_adapter_->RemoveObserver(this);
+  bluetooth_observer_flag_ = false;
 }
 
 void ArcBluetoothBridge::AdapterPoweredChanged(BluetoothAdapter* adapter,
                                                bool powered) {
   if (!HasBluetoothInstance())
     return;
 
   // TODO(smbarber): Invoke EnableAdapter or DisableAdapter via ARC bridge
   // service.
 }
@@ skipping 1408 matching lines @@
   LOG(WARNING) << "Bluetooth instance is too old (version " << version
                << ") need version " << version_need;
   return false;
 }
 
 bool ArcBluetoothBridge::CalledOnValidThread() {
   return thread_checker_.CalledOnValidThread();
 }
 
 }  // namespace arc