Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2223193003: Add an accessor to HeadlessBrowser for the IO thread (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
Sami, altimin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an accessor to HeadlessBrowser for the IO thread BUG=546953 Committed: https://crrev.com/7b27f6e0419b7896a23029ed96581e10f2bcf010 Cr-Commit-Position: refs/heads/master@{#410637}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M headless/lib/browser/headless_browser_impl.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 1 1 chunk +10 lines, -4 lines 0 comments Download
M headless/public/headless_browser.h View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-08-09 09:29:49 UTC) #3
altimin
lgtm with nit https://codereview.chromium.org/2223193003/diff/1/headless/lib/browser/headless_browser_impl.h File headless/lib/browser/headless_browser_impl.h (right): https://codereview.chromium.org/2223193003/diff/1/headless/lib/browser/headless_browser_impl.h#newcode43 headless/lib/browser/headless_browser_impl.h:43: scoped_refptr<base::SingleThreadTaskRunner> BrowserIoThread() const override; nit: BrowserIOThread?
4 years, 4 months ago (2016-08-09 10:38:15 UTC) #8
alex clarke (OOO till 29th)
https://codereview.chromium.org/2223193003/diff/1/headless/lib/browser/headless_browser_impl.h File headless/lib/browser/headless_browser_impl.h (right): https://codereview.chromium.org/2223193003/diff/1/headless/lib/browser/headless_browser_impl.h#newcode43 headless/lib/browser/headless_browser_impl.h:43: scoped_refptr<base::SingleThreadTaskRunner> BrowserIoThread() const override; On 2016/08/09 10:38:15, altimin wrote: ...
4 years, 4 months ago (2016-08-09 10:40:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223193003/20001
4 years, 4 months ago (2016-08-09 10:41:28 UTC) #12
Sami
lgtm.
4 years, 4 months ago (2016-08-09 10:55:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 12:03:32 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 12:04:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b27f6e0419b7896a23029ed96581e10f2bcf010
Cr-Commit-Position: refs/heads/master@{#410637}

Powered by Google App Engine
This is Rietveld 408576698