Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2223183002: Remove "< 7 minutes system startup" from startup metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self-review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9cd12ae7cb4aa277d187580ca00b95e3dcc5f82d..85191e843fa45b7d5d7952e5c033cce3e61c5fcf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -56187,6 +56187,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry" units="ms">
+ <obsolete>
+ Deprecated as of 08/2016. Replaced with
+ Startup.BrowserMessageLoopStartTimeFromMainEntry2 which is not only recorded
+ after 7 minutes of OS uptime.
+ </obsolete>
gab 2016/08/10 16:45:35 Do not mark as obsolete yet (otherwise no point re
fdoray 2016/08/23 14:50:16 Done.
<owner>jeremy@chromium.org</owner>
<summary>
Time from main entry to the start of the main thread's message loop. This
@@ -56197,6 +56202,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun"
units="ms">
+ <obsolete>
+ Deprecated as of 08/2016. Replaced with
+ Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2 which is not only
+ recorded after 7 minutes of OS uptime.
+ </obsolete>
<owner>csharp@chromium.org</owner>
<owner>gab@chromium.org</owner>
<owner>jeremy@chromium.org</owner>
@@ -56207,6 +56217,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2"
+ units="ms">
+ <owner>csharp@chromium.org</owner>
+ <owner>gab@chromium.org</owner>
+ <owner>jeremy@chromium.org</owner>
gab 2016/08/10 16:45:35 Ask them as FYI but I think proper modern owners f
fdoray 2016/08/23 14:50:16 Done.
+ <summary>
+ Time from main entry to the start of the main thread's message loop on first
+ run.
+ </summary>
+</histogram>
+
+<histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2" units="ms">
+ <owner>jeremy@chromium.org</owner>
+ <summary>
+ Time from main entry to the start of the main thread's message loop.
+ </summary>
+</histogram>
+
<histogram name="Startup.BrowserOpenTabs">
<owner>jeremy@chromium.org</owner>
<summary>
@@ -56506,6 +56534,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="Startup.LoadTime.ExeMainToDllMain">
+ <obsolete>
+ Deprecated as of 08/2016. Replaced with Startup.LoadTime.ExeMainToDllMain2
+ which is not only recorded after 7 minutes of OS uptime.
+ </obsolete>
<owner>jeremy@chromium.org</owner>
<summary>
Time from the main() function in chrome.exe to chrome.dll's main(). This
@@ -56514,7 +56546,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Startup.LoadTime.ExeMainToDllMain2">
+ <owner>jeremy@chromium.org</owner>
+ <summary>
+ Time from the main() function in chrome.exe to chrome.dll's main().
+ </summary>
+</histogram>
+
<histogram name="Startup.LoadTime.ProcessCreateToDllMain">
+ <obsolete>
+ Deprecated as of 08/2016. Replaced with
+ Startup.LoadTime.ProcessCreateToDllMain2 which is not only recorded after 7
+ minutes of OS uptime.
+ </obsolete>
<owner>jeremy@chromium.org</owner>
<summary>
Time from the process creation to chrome.dll's main(). This stat is only
@@ -56523,7 +56567,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Startup.LoadTime.ProcessCreateToDllMain2">
+ <owner>jeremy@chromium.org</owner>
+ <summary>Time from the process creation to chrome.dll's main().</summary>
+</histogram>
+
<histogram name="Startup.LoadTime.ProcessCreateToExeMain">
+ <obsolete>
+ Deprecated as of 08/2016. Replaced with
+ Startup.LoadTime.ProcessCreateToExeMain2 which is not only recorded after 7
+ minutes of OS uptime.
+ </obsolete>
<owner>jeremy@chromium.org</owner>
<summary>
Time from the process creation to executing the main() function in
@@ -56532,6 +56586,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Startup.LoadTime.ProcessCreateToExeMain2">
+ <owner>jeremy@chromium.org</owner>
+ <summary>
+ Time from the process creation to executing the main() function in
+ chrome.exe.
+ </summary>
+</histogram>
+
<histogram name="Startup.OSX.AwakeFromNib" units="ms">
<owner>erikchen@chromium.org</owner>
<summary>
@@ -101492,6 +101554,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.BrowserMessageLoopStartHardFaultCount"/>
<affected-histogram name="Startup.BrowserMessageLoopStartTime"/>
<affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry"/>
+ <affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2"/>
<affected-histogram name="Startup.BrowserOpenTabs"/>
<affected-histogram name="Startup.BrowserWindowDisplay"/>
<affected-histogram name="Startup.FirstWebContents.MainFrameLoad2"/>
@@ -101499,8 +101562,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.FirstWebContents.MainNavigationStart"/>
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint2"/>
<affected-histogram name="Startup.LoadTime.ExeMainToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ExeMainToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain2"/>
<affected-histogram name="Startup.SystemUptime"/>
<affected-histogram name="Startup.Temperature"/>
<affected-histogram name="Startup.TimeSinceLastStartup"/>
@@ -102088,6 +102154,9 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry"/>
<affected-histogram
name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun"/>
+ <affected-histogram
+ name="Startup.BrowserMessageLoopStartTimeFromMainEntry.FirstRun2"/>
+ <affected-histogram name="Startup.BrowserMessageLoopStartTimeFromMainEntry2"/>
<affected-histogram name="Startup.BrowserOpenTabs"/>
<affected-histogram name="Startup.BrowserWindowDisplay"/>
<affected-histogram name="Startup.FirstWebContents.MainFrameLoad"/>
@@ -102097,8 +102166,11 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint"/>
<affected-histogram name="Startup.FirstWebContents.NonEmptyPaint2"/>
<affected-histogram name="Startup.LoadTime.ExeMainToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ExeMainToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToDllMain2"/>
<affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain"/>
+ <affected-histogram name="Startup.LoadTime.ProcessCreateToExeMain2"/>
<affected-histogram name="Startup.SystemUptime"/>
<affected-histogram name="Startup.TimeSinceLastStartup"/>
</histogram_suffixes>

Powered by Google App Engine
This is Rietveld 408576698