Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2223173002: Disable flaky tests under Dr. Memory. (Closed)

Created:
4 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky tests under Dr. Memory. DumpAccessibilityTreeTest.AccessibilityIframeTransform is flaky under Dr. Memory. It looks like we already have an Uber-bug for this issue. * Line Expected - ---- -------- 1 rootWebArea pageLocation=(0, 0) 2 ++iframe pageLocation=(0, 0) 3 ++++rootWebArea pageLocation=(0, 0) 4 ++++++image pageLocation=(10, 10) pageSize=(200, 200) 5 ++iframe pageLocation=(0, 300) * 6 ++++rootWebArea pageLocation=(0, 300) transform 7 ++++++image pageLocation=(20, 320) pageSize=(400, 400) 8 <-- End-of-file --> Actual ------ rootWebArea pageLocation=(0, 0) ++iframe pageLocation=(0, 0) ++++rootWebArea pageLocation=(0, 0) ++++++image pageLocation=(10, 10) pageSize=(200, 200) ++iframe pageLocation=(0, 300) <-- End-of-file --> BUG=622387 TBR=thestig@chromium.org NOTRY=True Committed: https://crrev.com/88901f962512dfb1950e5b02722b93536acc94ad Cr-Commit-Position: refs/heads/master@{#410412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223173002/1
4 years, 4 months ago (2016-08-08 19:37:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:07:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/88901f962512dfb1950e5b02722b93536acc94ad Cr-Commit-Position: refs/heads/master@{#410412}
4 years, 4 months ago (2016-08-08 20:09:05 UTC) #5
Lei Zhang
4 years, 4 months ago (2016-08-08 21:42:08 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698