Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2223163002: [layoutng] Rename exclusion types to avoid conflicts with ComputedStyleConstants.h (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Rename exclusion types to avoid conflicts with ComputedStyleConstants.h R=ikilpatrick@chromium.org BUG=591099 Committed: https://crrev.com/70f373450652eb701351c3a7562ea2c13f737990 Cr-Commit-Position: refs/heads/master@{#410453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
cbiesinger
4 years, 4 months ago (2016-08-08 19:07:17 UTC) #1
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-08 19:07:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223163002/1
4 years, 4 months ago (2016-08-08 19:09:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/273422)
4 years, 4 months ago (2016-08-08 19:54:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223163002/1
4 years, 4 months ago (2016-08-08 20:08:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:52:44 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:55:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70f373450652eb701351c3a7562ea2c13f737990
Cr-Commit-Position: refs/heads/master@{#410453}

Powered by Google App Engine
This is Rietveld 408576698