Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223143002: [Chromedriver] Disable testColdExecuteScript Py test on HEAD (Closed)

Created:
4 years, 4 months ago by gmanikpure
Modified:
4 years, 4 months ago
Reviewers:
samuong
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Disable testColdExecuteScript Py test on HEAD BUG=chromedriver:1450 Committed: https://crrev.com/ff162e64d53e5c9d9833b5b376ef6bc63e68a8d3 Cr-Commit-Position: refs/heads/master@{#410411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gmanikpure
4 years, 4 months ago (2016-08-08 17:34:36 UTC) #2
samuong
lgtm
4 years, 4 months ago (2016-08-08 18:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223143002/1
4 years, 4 months ago (2016-08-08 18:53:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:06:33 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ff162e64d53e5c9d9833b5b376ef6bc63e68a8d3 Cr-Commit-Position: refs/heads/master@{#410411}
4 years, 4 months ago (2016-08-08 20:09:04 UTC) #8
samuong
4 years, 4 months ago (2016-08-12 16:15:24 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2240853003/ by samuong@chromium.org.

The reason for reverting is: This test was broken because the ChromeDriver
reference builds were out-of-date. I've updated them now, so I'm reverting this
CL to re-enable the test. See the bug for more context..

Powered by Google App Engine
This is Rietveld 408576698