Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2223133002: Revert "Return futures on Stream.cancel when possible." (Closed)

Created:
4 years, 4 months ago by floitsch
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Return futures on Stream.cancel when possible." This reverts commit 1905ddafaa242883891e2fb2d706e2dfa059a71b. Committed: https://github.com/dart-lang/sdk/commit/46a8579c1eb58f6a36a7d094d9b7824c92873de4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -553 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/async/stream.dart View 5 chunks +4 lines, -8 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 7 chunks +10 lines, -19 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_controller_test.dart View 4 chunks +233 lines, -276 lines 0 comments Download
M tests/lib/async/stream_periodic_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 7 chunks +6 lines, -52 lines 0 comments Download
M tests/lib/async/stream_subscription_cancel_test.dart View 2 chunks +2 lines, -186 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
floitsch
TBR. Pub and dart_style fail. pub: pub run test test/serve/web_socket/unserve_directory_test.dart dartfmt: python tools/test.py -mrelease --use-sdk ...
4 years, 4 months ago (2016-08-08 17:30:39 UTC) #2
floitsch
4 years, 4 months ago (2016-08-08 17:31:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46a8579c1eb58f6a36a7d094d9b7824c92873de4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698