[Profiles] Download high-res avatars using the --new-profile-management flag

chrome/browser/ui/webui/options/manage_profile_handler.cc

Index: chrome/browser/ui/webui/options/manage_profile_handler.cc
diff --git a/chrome/browser/ui/webui/options/manage_profile_handler.cc b/chrome/browser/ui/webui/options/manage_profile_handler.cc
index bc8c2d6094f30dc784b5da14ee273fa420c6e3ac..4cd5268bba0e3fb588365958bf0370dc646eb2a7 100644
--- a/chrome/browser/ui/webui/options/manage_profile_handler.cc
+++ b/chrome/browser/ui/webui/options/manage_profile_handler.cc
@@ -32,6 +32,7 @@
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/signin/core/browser/signin_manager.h"
+#include "components/signin/core/common/profile_management_switches.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_ui.h"
@@ -348,6 +349,10 @@ void ManageProfileHandler::SetProfileIconAndName(const base::ListValue* args) {
     }
   } else if (profiles::IsDefaultAvatarIconUrl(icon_url, &new_icon_index)) {
     ProfileMetrics::LogProfileAvatarSelection(new_icon_index);
+
+    if (switches::IsNewAvatarMenu())

[msw, 2014/04/29 21:17:33]

Do other paths that set the profile's icon also need to initiate high res
resource downloads? For example, ProfileManager::InitProfileUserPrefs and
SupervisedUserPrefMappingService::OnSharedSettingChanged.

I think this and the two calls below ought to be an internal details of the
cache, invoked through a public method like
ProfileInfoCache::SetAvatarIconIndexOfProfileAtIndex (like
GetAvatarIconIndexOfProfileAtIndex).

[noms (inactive), 2014/04/30 15:59:00]

Done.

+      cache.DownloadHighResAvatar(new_icon_index);
+
     PrefService* pref_service = profile->GetPrefs();
     // Updating the profile preference will cause the cache to be updated for
     // this preference.