[Profiles] Download high-res avatars using the --new-profile-management flag

chrome/browser/profiles/profiles_state.h

Index: chrome/browser/profiles/profiles_state.h
diff --git a/chrome/browser/profiles/profiles_state.h b/chrome/browser/profiles/profiles_state.h
index 9f0178d3016e944b05635ce62acef2f9ceb37ff9..6a4fd6372884b68153fb2a0af3bd245c511889de 100644
--- a/chrome/browser/profiles/profiles_state.h
+++ b/chrome/browser/profiles/profiles_state.h
@@ -48,6 +48,9 @@ std::vector<std::string> GetSecondaryAccountsForProfile(
 // incognito profiles.
 bool IsRegularOrGuestSession(Browser* browser);
 
+// If the file doesn't already exist, starts a download for the high res

[msw, 2014/04/28 20:46:37]

This seems out of place here. Aren't icon indices generally disliked?

[noms (inactive), 2014/04/29 19:12:27]

I'm sure they are disliked, but the avatar index is the only thing that's
available (this function needs to be called when changing a profile's avatar,
which just gives you the index of the new avatar). It's indexes all the way down
:(

On 2014/04/28 20:46:37, msw wrote:

[msw, 2014/04/29 20:11:44]

This can be removed; the only caller is
ManageProfileHandler::SetProfileIconAndName, which already uses its
ProfileInfoCache locally, so it can easily call
cache.DownloadHighResAvatar(new_icon_index); directly. Please move the TODO
comment inside this function impl (about avoiding re-downloading avatar
resources) to the DownloadHighResAvatar declaration.

[noms (inactive), 2014/04/29 20:29:10]

Done.

+// avatar at |icon_index|.
+void DownloadHighResAvatarIfNeeded(size_t icon_index);
 }  // namespace profiles
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILES_STATE_H_