[Profiles] Download high-res avatars using the --new-profile-management flag

chrome/browser/profiles/profile_avatar_downloader.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profiles/profile_avatar_downloader.h"
+
+#include "base/files/file_path.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_avatar_icon_util.h"
+#include "chrome/browser/profiles/profile_info_cache.h"
+
+namespace {
+const char kHighResAvatarDownloadUrlPrefix[] =
+    "http://www.gstatic.com/chrome/profile_avatars/";
+}
+
+ProfileAvatarDownloader::ProfileAvatarDownloader(
+    net::URLRequestContextGetter* request_context,
+    size_t icon_index,
+    ProfileInfoCache* cache)
+    : request_context_(request_context),
+      icon_index_(icon_index),
+      cache_(cache) {
+  GURL url(std::string(kHighResAvatarDownloadUrlPrefix) +
+           profiles::GetDefaultAvatarIconFileNameAtIndex(icon_index));
+  fetcher_.reset(new chrome::BitmapFetcher(url, this));
+}
+
+ProfileAvatarDownloader::~ProfileAvatarDownloader() {
+}
+
+void ProfileAvatarDownloader::Start() {
+  fetcher_->Start(request_context_);
+}
+
+// BitmapFetcherDelegate overrides.
+void ProfileAvatarDownloader::OnFetchComplete(const GURL url,
+                                              const SkBitmap* bitmap) {
+  if (!bitmap) {

[msw, 2014/04/28 20:46:37]

nit: drop unnecessary braces.

[noms (inactive), 2014/04/29 19:12:27]

Done.

+    return;
+  }
+
+  // Decode the downloaded bitmap. Ownership of the pointer is taken by
+  // |cached_avatar_images_|.

[msw, 2014/04/28 20:46:37]

nit: mention ProfileInfoCache, not an internal member, cached_avatar_images_.

[noms (inactive), 2014/04/29 19:12:27]

Done.

+  gfx::Image* image = new gfx::Image(gfx::Image::CreateFrom1xBitmap(*bitmap));
+  cache_->SaveAvatarImageAtPath(image,

[msw, 2014/04/28 20:46:37]

Is the cache guaranteed to be alive when this is called?

[noms (inactive), 2014/04/29 19:12:27]

It should be. I have added a check to bail early if this is not the case,
though. 
On 2014/04/28 20:46:37, msw wrote:

+      profiles::GetDefaultAvatarIconFileNameAtIndex(icon_index_),
+      profiles::GetPathOfHighResAvatarAtIndex(icon_index_));
+}