Issue 222313004: PNaCl bitcode reader: restrict some record sizes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222313004: PNaCl bitcode reader: restrict some record sizes (Closed)

Created:
6 years, 8 months ago by JF

Modified:
6 years, 8 months ago

Reviewers:
jvoung (off chromium), kschimpf, Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

PNaCl bitcode reader: restrict some record sizes The PNaCl bitcode reader allows too many entries in some records, and these extra entries never happen in practice. This change makes sure we don't allow and then ignore too many things in the bitcode format. This came up in: https://codereview.chromium.org/221693002/ R=kschimpf@google.com, jvoung@chromium.org, kschimpf@chromium.org TEST= ./scons small_tests medium_tests bitcode=1 BUG= none Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=6110bae

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -15 lines)			Patch
	M	lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp	View		5 chunks	+27 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

6 years, 8 months ago (2014-04-02 23:25:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r6110bae (presubmit successful).