DevTools: Add custom CPU throttling option to timeline.

DevTools: Add custom CPU throttling option to timeline.

BUG=436111
Committed: https://crrev.com/b395bf5af79897fcda732779a493cc60bbe5fcdb
Cr-Commit-Position: refs/heads/master@{#411236}

[alph, 2016-08-09 01:16:06]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[alph, 2016-08-09 01:18:27]

Description was changed from

==========
DevTools: Add custom CPU throttling option to timeline.
==========

to

==========
DevTools: Add custom CPU throttling option to timeline.

BUG=436111
==========

[alph, 2016-08-09 20:30:34]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org
- caseq@chromium.org

[alph, 2016-08-10 17:50:01]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[alph, 2016-08-10 17:50:02]

ptal

[caseq, 2016-08-10 18:28:48]

lgtm

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:441:
addGroupingOption(WebInspector.UIString("Custom rate%s\u2026", customRate), 0);
addGroupingOption(predefinedRates.has(currentRate) ? WebInspector.UIString(...)
: WebInspector.UIString(...)) -- this is better from l10n prospective.

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:579: if
(value === "0")
can we have some other check here? Either check for selectedIndex or have a more
descriptive constant than "0"?

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:2060: *
@param {function(string)} callback
use a promise perhaps?

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:2065:
this.registerRequiredCSS("ui_lazy/dialog.css");
can this be taken care of by Dialog?

[alph, 2016-08-10 21:14:22]

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:441:
addGroupingOption(WebInspector.UIString("Custom rate%s\u2026", customRate), 0);
On 2016/08/10 18:28:47, caseq wrote:
> addGroupingOption(predefinedRates.has(currentRate) ?
WebInspector.UIString(...)
> : WebInspector.UIString(...)) -- this is better from l10n prospective.

Done.

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:579: if
(value === "0")
On 2016/08/10 18:28:47, caseq wrote:
> can we have some other check here? Either check for selectedIndex or have a
more
> descriptive constant than "0"?

Done.

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:2060: *
@param {function(string)} callback
On 2016/08/10 18:28:47, caseq wrote:
> use a promise perhaps?

Done.

https://codereview.chromium.org/2223123003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:2065:
this.registerRequiredCSS("ui_lazy/dialog.css");
On 2016/08/10 18:28:47, caseq wrote:
> can this be taken care of by Dialog?

Looks like a separate CL.

[alph, 2016-08-10 21:23:50]

The CQ bit was checked by alph@chromium.org

[alph, 2016-08-10 21:23:51]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2223123003/#ps40001
(title: "addressing caseq comments.")

[commit-bot: I haz the power, 2016-08-10 21:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:24:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:24:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alph, 2016-08-10 22:27:44]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:28:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:25:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:25:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2016-08-11 00:27:33]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:54:53]

Description was changed from

==========
DevTools: Add custom CPU throttling option to timeline.

BUG=436111
==========

to

==========
DevTools: Add custom CPU throttling option to timeline.

BUG=436111
==========

[commit-bot: I haz the power, 2016-08-11 02:54:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 02:56:15]

Description was changed from

==========
DevTools: Add custom CPU throttling option to timeline.

BUG=436111
==========

to

==========
DevTools: Add custom CPU throttling option to timeline.

BUG=436111

Committed: https://crrev.com/b395bf5af79897fcda732779a493cc60bbe5fcdb
Cr-Commit-Position: refs/heads/master@{#411236}
==========

[commit-bot: I haz the power, 2016-08-11 02:56:16]

Patchset 3 (id:??) landed as
https://crrev.com/b395bf5af79897fcda732779a493cc60bbe5fcdb
Cr-Commit-Position: refs/heads/master@{#411236}