Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(909)

Issue 2223103002: Update pdfium/annots/annotation_square_fill_negative_border_expected.pdf.0.png. (Closed)

Created:
4 years, 1 month ago by jaepark
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium_tests@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pdfium/annots/annotation_square_fill_negative_border_expected.pdf.0.png. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/7f07c2223bfb8114dc5060ecdc51793bba1c90d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M pdfium/annots/annotation_square_fill_negative_border_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 7 (2 generated)
jaepark
Updated test case after modifying implementation about negative border width in https://codereview.chromium.org/2219683002/ .
4 years, 1 month ago (2016-08-08 17:18:28 UTC) #2
Lei Zhang
It's not obvious to the eyeball what the difference is.
4 years, 1 month ago (2016-08-08 19:36:19 UTC) #3
jaepark
On 2016/08/08 19:36:19, Lei Zhang wrote: > It's not obvious to the eyeball what the ...
4 years, 1 month ago (2016-08-08 21:52:03 UTC) #4
Lei Zhang
lgtm
4 years, 1 month ago (2016-08-08 22:21:32 UTC) #5
jaepark
4 years, 1 month ago (2016-08-08 22:41:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f07c2223bfb8114dc5060ecdc51793bba1c90d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698