Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2223073002: Add per-section clearing and dismissed suggestions to snippets-internals (Closed)

Created:
4 years, 4 months ago by Philipp Keck
Modified:
4 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add per-section clearing and dismissed suggestions to snippets-internals Add new ClearCachedSuggestionsForDebugging, GetDismissedSuggestionsForDebugging and ClearDismissedSuggestionsForDebugging methods to the ContentSuggestionsProvider. Implement these methods in all existing providers. Adjust the unit tests. Call those methods from snippets-internals, build new internals UI for viewing dismissed suggestions and clearing suggestions per category. Remove now unused NTPSnippetsService-related things. BUG=619560 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86 Cr-Commit-Position: refs/heads/master@{#410640}

Patch Set 1 #

Patch Set 2 : Fix non-Debug builds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -388 lines) Patch
M chrome/browser/resources/snippets_internals.html View 6 chunks +58 lines, -99 lines 0 comments Download
M chrome/browser/resources/snippets_internals.js View 7 chunks +29 lines, -38 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 1 8 chunks +51 lines, -104 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc View 2 chunks +16 lines, -3 lines 0 comments Download
M components/ntp_snippets/content_suggestions_provider.h View 1 chunk +15 lines, -7 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 1 chunk +22 lines, -8 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 1 chunk +29 lines, -6 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 3 chunks +9 lines, -13 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +62 lines, -37 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 24 chunks +68 lines, -61 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h View 1 chunk +4 lines, -2 lines 0 comments Download
M components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Philipp Keck
This is a new version of https://codereview.chromium.org/2222853004/, which was reverted (https://codereview.chromium.org/2225753003/). PTAL
4 years, 4 months ago (2016-08-08 17:48:29 UTC) #2
Philipp Keck
PTAL
4 years, 4 months ago (2016-08-08 17:48:51 UTC) #4
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-09 09:21:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223073002/20001
4 years, 4 months ago (2016-08-09 09:25:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-09 12:15:41 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 12:17:34 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/151b550fbd93427200cfddd13c5fdea68ea38d86
Cr-Commit-Position: refs/heads/master@{#410640}

Powered by Google App Engine
This is Rietveld 408576698