find_unmapped_histograms.py: filter filenames

find_unmapped_histograms.py: filter filenames

Reduce false positives from tools/metrics/find_unmapped_histograms.py by
skipping file names that are not C++ or Objective C++, and also skipping
filenames for tests.

Diff before / after this change:

***************
*** 23,26 ****
  WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram name <time_per.c_str(>
- WARNING: tools/metrics/histograms/find_unmapped_histograms.py contains non-literal histogram name <'
-   locations = RunGit(['gs'>
  WARNING: cc/raster/gpu_raster_buffer_provider.cc contains non-literal histogram name <base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.Gpu">
--- 23,24 ----
***************
*** 60,62 ****
  INFO:   BeginResult - 0x6f42084be75ea43b
- INFO:   Bla.Foo.Dummy - 0x0c89f87e6b2dcf94
  INFO:   Bookmarks.CreateBookmarkIndexTime - 0x22dbb7a64293f927
--- 58,59 ----
***************
*** 156,158 ****
  INFO:   Flash.UsesGPU - 0x19301ada6a59b0e9
- INFO:   FooGroup.FooName - 0xbabc9e98ceaccbdf
  INFO:   GCM.DataMessageReceived - 0x6ac32c312317b760
--- 153,154 ----
***************
*** 265,270 ****
  INFO:   Shutdown.renderers.total - 0xaf283dea3598b176
- INFO:   Snafu_Dummy - 0x9d01478e32b83f00
  INFO:   SoftwareReporter.Cleaner.ExitCode - 0x1f78f7cc99e41d01
  INFO:   SoftwareReporter.ExitCode - 0x943ddee9c3ecc370
- INFO:   Sparse - 0x7407fb7e6a4df639
  INFO:   SpellCheck.CheckedWords - 0xb64739e0c80469f2
--- 261,264 ----
***************
*** 296,301 ****
  INFO:   TabRestore.read_session_file_time - 0x95a3ff3d6e153b3a
- INFO:   TestLongTimer0 - 0x85050dce02aa6dad
- INFO:   TestLongTimer1 - 0x5c0a19ba0b8828a1
- INFO:   TestTimer0 - 0xa180e82fa5050e6a
- INFO:   TestTimer1 - 0x95e83004778c4340
  INFO:   TextInputClient.CharacterIndex - 0x518547f3e632e446
--- 290,291 ----
***************
*** 307,311 ****
  INFO:   Touchpad.ThreeFingerClick.Started - 0x708f17ee567d8f4e
- INFO:   UmaHistogram - 0x46fb9873be49b3d1
- INFO:   UmaHistogramManager - 0x931b3d1b039fcfcb
- INFO:   UmaHistogramManager2 - 0xf6ec768ea672eae9
  INFO:   Unknown - 0x88183b946cc5f0e8
--- 297,298 ----
***************
*** 317,319 ****
  INFO:   WebP.DecodedImageFormat - 0xb8cc017ee20467b6
- INFO:   test - 0x098f6bcd4621d373
  INFO:   websql.Async.VacuumResult - 0x0abe7435cacb1f70

R=isherman@chromium.org
BUG=635449
Committed: https://crrev.com/e4cb8812fb938cec4dad22432e83fac155227089
Cr-Commit-Position: refs/heads/master@{#411940}

[Ilya Sherman, 2016-08-10 06:23:10]

LGTM, thanks.

[Adam Rice, 2016-08-15 05:01:33]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-15 05:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2223063004/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-15 05:01:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 05:45:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 05:47:45]

Description was changed from

==========
find_unmapped_histograms.py: filter filenames

Reduce false positives from tools/metrics/find_unmapped_histograms.py by
skipping file names that are not C++ or Objective C++, and also skipping
filenames for tests.

Diff before / after this change:

***************
*** 23,26 ****
  WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram
name <time_per.c_str(>
- WARNING: tools/metrics/histograms/find_unmapped_histograms.py contains
non-literal histogram name <'
-   locations = RunGit(['gs'>
  WARNING: cc/raster/gpu_raster_buffer_provider.cc contains non-literal
histogram name
<base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.Gpu">
--- 23,24 ----
***************
*** 60,62 ****
  INFO:   BeginResult - 0x6f42084be75ea43b
- INFO:   Bla.Foo.Dummy - 0x0c89f87e6b2dcf94
  INFO:   Bookmarks.CreateBookmarkIndexTime - 0x22dbb7a64293f927
--- 58,59 ----
***************
*** 156,158 ****
  INFO:   Flash.UsesGPU - 0x19301ada6a59b0e9
- INFO:   FooGroup.FooName - 0xbabc9e98ceaccbdf
  INFO:   GCM.DataMessageReceived - 0x6ac32c312317b760
--- 153,154 ----
***************
*** 265,270 ****
  INFO:   Shutdown.renderers.total - 0xaf283dea3598b176
- INFO:   Snafu_Dummy - 0x9d01478e32b83f00
  INFO:   SoftwareReporter.Cleaner.ExitCode - 0x1f78f7cc99e41d01
  INFO:   SoftwareReporter.ExitCode - 0x943ddee9c3ecc370
- INFO:   Sparse - 0x7407fb7e6a4df639
  INFO:   SpellCheck.CheckedWords - 0xb64739e0c80469f2
--- 261,264 ----
***************
*** 296,301 ****
  INFO:   TabRestore.read_session_file_time - 0x95a3ff3d6e153b3a
- INFO:   TestLongTimer0 - 0x85050dce02aa6dad
- INFO:   TestLongTimer1 - 0x5c0a19ba0b8828a1
- INFO:   TestTimer0 - 0xa180e82fa5050e6a
- INFO:   TestTimer1 - 0x95e83004778c4340
  INFO:   TextInputClient.CharacterIndex - 0x518547f3e632e446
--- 290,291 ----
***************
*** 307,311 ****
  INFO:   Touchpad.ThreeFingerClick.Started - 0x708f17ee567d8f4e
- INFO:   UmaHistogram - 0x46fb9873be49b3d1
- INFO:   UmaHistogramManager - 0x931b3d1b039fcfcb
- INFO:   UmaHistogramManager2 - 0xf6ec768ea672eae9
  INFO:   Unknown - 0x88183b946cc5f0e8
--- 297,298 ----
***************
*** 317,319 ****
  INFO:   WebP.DecodedImageFormat - 0xb8cc017ee20467b6
- INFO:   test - 0x098f6bcd4621d373
  INFO:   websql.Async.VacuumResult - 0x0abe7435cacb1f70

R=isherman@chromium.org
BUG=635449
==========

to

==========
find_unmapped_histograms.py: filter filenames

Reduce false positives from tools/metrics/find_unmapped_histograms.py by
skipping file names that are not C++ or Objective C++, and also skipping
filenames for tests.

Diff before / after this change:

***************
*** 23,26 ****
  WARNING: chrome/browser/browser_shutdown.cc contains non-literal histogram
name <time_per.c_str(>
- WARNING: tools/metrics/histograms/find_unmapped_histograms.py contains
non-literal histogram name <'
-   locations = RunGit(['gs'>
  WARNING: cc/raster/gpu_raster_buffer_provider.cc contains non-literal
histogram name
<base::StringPrintf("Renderer4.%s.PartialRasterPercentageSaved.Gpu">
--- 23,24 ----
***************
*** 60,62 ****
  INFO:   BeginResult - 0x6f42084be75ea43b
- INFO:   Bla.Foo.Dummy - 0x0c89f87e6b2dcf94
  INFO:   Bookmarks.CreateBookmarkIndexTime - 0x22dbb7a64293f927
--- 58,59 ----
***************
*** 156,158 ****
  INFO:   Flash.UsesGPU - 0x19301ada6a59b0e9
- INFO:   FooGroup.FooName - 0xbabc9e98ceaccbdf
  INFO:   GCM.DataMessageReceived - 0x6ac32c312317b760
--- 153,154 ----
***************
*** 265,270 ****
  INFO:   Shutdown.renderers.total - 0xaf283dea3598b176
- INFO:   Snafu_Dummy - 0x9d01478e32b83f00
  INFO:   SoftwareReporter.Cleaner.ExitCode - 0x1f78f7cc99e41d01
  INFO:   SoftwareReporter.ExitCode - 0x943ddee9c3ecc370
- INFO:   Sparse - 0x7407fb7e6a4df639
  INFO:   SpellCheck.CheckedWords - 0xb64739e0c80469f2
--- 261,264 ----
***************
*** 296,301 ****
  INFO:   TabRestore.read_session_file_time - 0x95a3ff3d6e153b3a
- INFO:   TestLongTimer0 - 0x85050dce02aa6dad
- INFO:   TestLongTimer1 - 0x5c0a19ba0b8828a1
- INFO:   TestTimer0 - 0xa180e82fa5050e6a
- INFO:   TestTimer1 - 0x95e83004778c4340
  INFO:   TextInputClient.CharacterIndex - 0x518547f3e632e446
--- 290,291 ----
***************
*** 307,311 ****
  INFO:   Touchpad.ThreeFingerClick.Started - 0x708f17ee567d8f4e
- INFO:   UmaHistogram - 0x46fb9873be49b3d1
- INFO:   UmaHistogramManager - 0x931b3d1b039fcfcb
- INFO:   UmaHistogramManager2 - 0xf6ec768ea672eae9
  INFO:   Unknown - 0x88183b946cc5f0e8
--- 297,298 ----
***************
*** 317,319 ****
  INFO:   WebP.DecodedImageFormat - 0xb8cc017ee20467b6
- INFO:   test - 0x098f6bcd4621d373
  INFO:   websql.Async.VacuumResult - 0x0abe7435cacb1f70

R=isherman@chromium.org
BUG=635449

Committed: https://crrev.com/e4cb8812fb938cec4dad22432e83fac155227089
Cr-Commit-Position: refs/heads/master@{#411940}
==========

[commit-bot: I haz the power, 2016-08-15 05:47:46]

Patchset 2 (id:??) landed as
https://crrev.com/e4cb8812fb938cec4dad22432e83fac155227089
Cr-Commit-Position: refs/heads/master@{#411940}