Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2223063003: Move DisplayLayoutStore from ash to ui. (Closed)

Created:
4 years, 4 months ago by kylechar
Modified:
4 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DisplayLayoutStore from ash to ui. This CL moves DisplayLayoutStore from src/ash/display/ to src/ui/display/manager. This is so that DisplayLayoutStore can be used with services/ui/display/ code. Update references and move some utility functions and flags used by DisplayLayoutStore. BUG=625876 Committed: https://crrev.com/7eacccaaa5e5cb14cafbbb25cba892adf839fb5a Cr-Commit-Position: refs/heads/master@{#413148}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase/add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -227 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/ash_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/ash_switches.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/display/display_layout_store.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ash/display/display_layout_store.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M ash/display/display_manager.h View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/display/extended_mouse_warp_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/test/display_manager_test_api.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/display/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/display_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/display_switches.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + ui/display/manager/display_layout_store.h View 1 2 chunks +9 lines, -8 lines 0 comments Download
A + ui/display/manager/display_layout_store.cc View 1 2 3 chunks +36 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kylechar
There are two utility functions I've copied into display_layout_store.cc temporarily. Right now the functions are ...
4 years, 4 months ago (2016-08-09 18:06:06 UTC) #3
kylechar
Think you'll have time to take a look this week oshima?
4 years, 4 months ago (2016-08-17 16:22:00 UTC) #4
oshima
On 2016/08/17 16:22:00, kylechar wrote: > Think you'll have time to take a look this ...
4 years, 4 months ago (2016-08-17 23:57:10 UTC) #5
oshima
lgtm
4 years, 4 months ago (2016-08-18 18:28:22 UTC) #6
kylechar
Thanks oshima!
4 years, 4 months ago (2016-08-19 13:59:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223063003/40001
4 years, 4 months ago (2016-08-19 13:59:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-19 15:16:28 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:18:39 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7eacccaaa5e5cb14cafbbb25cba892adf839fb5a
Cr-Commit-Position: refs/heads/master@{#413148}

Powered by Google App Engine
This is Rietveld 408576698