Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2223023002:
Cleanup use of legacy SkSurface creation methods a bit (Closed)
|
Created:
4 years, 4 months ago by robertphillips Modified:
4 years, 4 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionCleanup use of legacy SkSurface creation methods a bit
This CL cleans up some remaining uses of the old API
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002
Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a
Committed: https://skia.googlesource.com/skia/+/5eca3e187e9a584f3c8162b04b452a8412e4665a
Patch Set 1 #Patch Set 2 : Clean up #Patch Set 3 : Rm public.bzl #
Messages
Total messages: 28 (19 generated)
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit ========== to ========== Cleanup use of legacy SkSurface creation methods a bit GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ==========
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ========== to ========== Cleanup use of legacy SkSurface creation methods a bit GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ==========
robertphillips@google.com changed reviewers: + benjaminwagner@google.com, egdaniel@google.com
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ========== to ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ==========
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
public.bzl lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 ========== to ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2220933004/ by robertphillips@google.com. The reason for reverting is: webkit_headless!.
Message was sent while issue was closed.
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ========== to ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit This: removes the SK_SUPPORT_LEGACY_NEW_SURFACE_API flag from the bzl build cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ========== to ========== Cleanup use of legacy SkSurface creation methods a bit This CL cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from benjaminwagner@google.com, egdaniel@google.com Link to the patchset: https://codereview.chromium.org/2223023002/#ps40001 (title: "Rm public.bzl")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
landing w/o .bzl changes
Message was sent while issue was closed.
Description was changed from ========== Cleanup use of legacy SkSurface creation methods a bit This CL cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a ========== to ========== Cleanup use of legacy SkSurface creation methods a bit This CL cleans up some remaining uses of the old API GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2223023002 Committed: https://skia.googlesource.com/skia/+/f21cd16228c20927fa4e9b937d6951471cfaa37a Committed: https://skia.googlesource.com/skia/+/5eca3e187e9a584f3c8162b04b452a8412e4665a ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/5eca3e187e9a584f3c8162b04b452a8412e4665a |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
