Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2222993003: [turbofan] Consume number type hints for strict equality. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Consume number type hints for strict equality. This allows us to consume the type hints gathered by the CompareIC for the strict equality and inequality operators. Similar to abstract equality We need to distinguish Number and NumberOrOddball feedback, as strict equality doesn't truncate Oddball to Number. R=epertoso@chromium.org BUG=v8:4583 Committed: https://crrev.com/76949ba4cccb78c97681337118f0245b8d3f2741 Cr-Commit-Position: refs/heads/master@{#38438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 7 chunks +17 lines, -14 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-08 12:09:19 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-08 12:15:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222993003/1
4 years, 4 months ago (2016-08-08 12:15:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 12:34:30 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 12:36:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76949ba4cccb78c97681337118f0245b8d3f2741
Cr-Commit-Position: refs/heads/master@{#38438}

Powered by Google App Engine
This is Rietveld 408576698