Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2222993002: Deprecate SVGSVGElement.viewport attribute (Closed)

Created:
4 years, 4 months ago by Shanmuga Pandi
Modified:
4 years, 3 months ago
Reviewers:
pdr., fs, foolip, rwlbuis
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate SVGSVGElement.viewport attribute SVGSVGElement.viewport removed from the spec. https://github.com/w3c/svgwg/commit/99a342c09dc0f8f164667d45d1c8486f0f87af8f Intent to Deprecate: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bFqDvZK2LVY BUG=395838 Committed: https://crrev.com/f7d24bd8050b6bf21e6280f12103f0c311e18f4f Cr-Commit-Position: refs/heads/master@{#411563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/svg/custom/detached-outermost-svg-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/immutable-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Shanmuga Pandi
PTAL!! Thanks
4 years, 4 months ago (2016-08-08 12:04:34 UTC) #4
fs
lgtm
4 years, 4 months ago (2016-08-08 14:58:18 UTC) #5
Shanmuga Pandi
Intent to Deprecate thread still not got the 3rd l-g-t-m.
4 years, 4 months ago (2016-08-11 06:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222993002/1
4 years, 4 months ago (2016-08-12 05:01:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 06:09:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f7d24bd8050b6bf21e6280f12103f0c311e18f4f Cr-Commit-Position: refs/heads/master@{#411563}
4 years, 4 months ago (2016-08-12 06:10:44 UTC) #12
foolip
Do you intend to remove this for M55? If so can you wrote on the ...
4 years, 3 months ago (2016-09-05 14:12:10 UTC) #13
Shanmuga Pandi
On 2016/09/05 14:12:10, foolip wrote: Updated intent thread. As per first LGTM1 comment, I did ...
4 years, 3 months ago (2016-09-06 05:22:08 UTC) #14
foolip
4 years, 3 months ago (2016-09-06 07:57:27 UTC) #15
Message was sent while issue was closed. 
On 2016/09/06 05:22:08, Shanmuga Pandi wrote:
> On 2016/09/05 14:12:10, foolip wrote:
> 
> Updated intent thread. As per first LGTM1 comment, I did changes for intent to
> remove for M55.

Great, that means that you can proceed with the removal right away, branch point
for M54 having already passed :)

Powered by Google App Engine
This is Rietveld 408576698