Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2222953003: [turbofan] Fix silly bug in loop variable analysis. (Closed)

Created:
4 years, 4 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix silly bug in loop variable analysis. Committed: https://crrev.com/ad8e0e2554e234aa727354912dfc478fb18bc91c Cr-Commit-Position: refs/heads/master@{#38448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/loop-variable-optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-loop-variable-if.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 4 months ago (2016-08-08 14:01:02 UTC) #4
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-08 15:10:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222953003/1
4 years, 4 months ago (2016-08-08 15:10:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 15:50:36 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:51:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad8e0e2554e234aa727354912dfc478fb18bc91c
Cr-Commit-Position: refs/heads/master@{#38448}

Powered by Google App Engine
This is Rietveld 408576698