Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc

Issue 2222933002: Make bookmark suggestions dismissable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make bookmark suggestions dismissable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
index 85457d2d8d568928e35f897e412e3415de495180..7453fd55878d0e5a0e2058455566592abd555911 100644
--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
@@ -66,8 +66,9 @@ CategoryStatus BookmarkSuggestionsProvider::GetCategoryStatus(
void BookmarkSuggestionsProvider::DismissSuggestion(
const std::string& suggestion_id) {
- // TODO(jkrcal): Implement blacklisting bookmarks until they are next visited.
- // Then also implement ClearDismissedSuggestionsForDebugging.
+ DCHECK(bookmark_model_->loaded());
+ GURL url(GetWithinCategoryIDFromUniqueID(suggestion_id));
+ MarkBookmarksDismissed(bookmark_model_, url);
}
void BookmarkSuggestionsProvider::FetchSuggestionImage(
@@ -82,7 +83,9 @@ void BookmarkSuggestionsProvider::ClearCachedSuggestionsForDebugging() {
}
void BookmarkSuggestionsProvider::ClearDismissedSuggestionsForDebugging() {
- // TODO(jkrcal): Implement when discarded suggestions are supported.
+ if (!bookmark_model_->loaded())
+ return;
+ MarkAllBookmarksUndismissed(bookmark_model_);
}
void BookmarkSuggestionsProvider::BookmarkModelLoaded(

Powered by Google App Engine
This is Rietveld 408576698