Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2222933002: Make bookmark suggestions dismissable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make bookmark suggestions dismissable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
index f5d9172679891d24d3984edf4b6e39b34f7a9da0..321722c7ce3d9516b60eb829bc8a8663b5dd3ced 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h
@@ -31,10 +31,21 @@ void UpdateBookmarkOnURLVisitedInMainFrame(
// this info, it returns it creation date.
base::Time GetLastVisitDateForBookmark(const bookmarks::BookmarkNode* node);
-// Returns the list of most recently visited bookmarks. For each bookmarked URL,
-// it returns the most recently created bookmark. The result is ordered by visit
-// time (the most recent first). Only bookmarks visited after
-// |min_visit_time| are considered, at most |max_count| bookmarks are returned.
+// Marks all bookmarks with the given URL as dismissed.
+void MarkBookmarksDismissed(bookmarks::BookmarkModel* bookmark_model,
+ const GURL& url);
+
+// Gets the dismissed flag for a given bookmark |node|. Defaults to false.
+bool GetDismissedFromNTPForBookmark(const bookmarks::BookmarkNode* node);
Marc Treib 2016/08/08 09:10:46 IsBookmarkDismissedFromNTP?
Philipp Keck 2016/08/08 09:42:25 Done.
+
+// Removes the dismissed flag from all bookmarks (only for debugging).
+void MarkAllBookmarksUndismissed(bookmarks::BookmarkModel* bookmark_model);
+
+// Returns the list of most recently visited, non-dismissed bookmarks.
+// For each bookmarked URL, it returns the most recently created bookmark.
+// The result is ordered by visit time (the most recent first). Only bookmarks
+// visited after |min_visit_time| are considered, at most |max_count| bookmarks
+// are returned.
std::vector<const bookmarks::BookmarkNode*> GetRecentlyVisitedBookmarks(
bookmarks::BookmarkModel* bookmark_model,
int max_count,

Powered by Google App Engine
This is Rietveld 408576698