Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 222293002: Port to x64 Android. (Closed)

Created:
6 years, 8 months ago by Anton
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Port to x64 Android. New compiler version complains about used before initialized. Compiler is wrong about this, but there is no harm in initializing. BUG=346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M courgette/disassembler_elf_32_arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Anton
6 years, 8 months ago (2014-04-02 18:36:29 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 8 months ago (2014-04-02 18:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/222293002/1
6 years, 8 months ago (2014-04-02 18:48:39 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 20:27:50 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=292827
6 years, 8 months ago (2014-04-02 20:27:50 UTC) #5
Anton
The CQ bit was checked by anton@chromium.org
6 years, 8 months ago (2014-04-03 09:59:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/222293002/1
6 years, 8 months ago (2014-04-03 10:00:26 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 11:35:47 UTC) #8
Message was sent while issue was closed.
Change committed as 261343

Powered by Google App Engine
This is Rietveld 408576698