Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/debug/mirrors.js

Issue 2222893002: Move family of MakeError functions to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix in prologue.js Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/mirrors.js
diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js
index 41c14afd5d33cd7c4aaf7bd62a8d6b064c4d0678..fbe6da5d8605408bd0bad86467e5cdfa30ff3c19 100644
--- a/src/debug/mirrors.js
+++ b/src/debug/mirrors.js
@@ -11,7 +11,6 @@
var GlobalArray = global.Array;
var IsNaN = global.isNaN;
var JSONStringify = global.JSON.stringify;
-var MakeError;
var MapEntries;
var MapIteratorNext;
var promiseStateSymbol = utils.ImportNow("promise_state_symbol");
@@ -20,7 +19,6 @@ var SetIteratorNext;
var SetValues;
utils.Import(function(from) {
- MakeError = from.MakeError;
MapEntries = from.MapEntries;
MapIteratorNext = from.MapIteratorNext;
SetIteratorNext = from.SetIteratorNext;
@@ -192,7 +190,7 @@ function MakeMirror(value, opt_transient) {
*/
function LookupMirror(handle) {
if (!mirror_cache_enabled_) {
- throw MakeError(kDebugger, "Mirror cache is disabled");
+ throw %make_error(kDebugger, "Mirror cache is disabled");
}
return mirror_cache_[handle];
}
@@ -2241,7 +2239,7 @@ ScopeDetails.prototype.setVariableValueImpl = function(name, new_value) {
raw_res = %SetScopeVariableValue(this.fun_value_, null, null, this.index_,
name, new_value);
}
- if (!raw_res) throw MakeError(kDebugger, "Failed to set variable value");
+ if (!raw_res) throw %make_error(kDebugger, "Failed to set variable value");
};
@@ -2340,7 +2338,7 @@ ScriptMirror.prototype.source = function() {
ScriptMirror.prototype.setSource = function(source) {
- if (!IS_STRING(source)) throw MakeError(kDebugger, "Source is not a string");
+ if (!IS_STRING(source)) throw %make_error(kDebugger, "Source is not a string");
%DebugSetScriptSource(this.script_, source);
};
@@ -2660,7 +2658,7 @@ JSONProtocolSerializer.prototype.serialize_ = function(mirror, reference,
case MirrorType.PROPERTY_TYPE:
case MirrorType.INTERNAL_PROPERTY_TYPE:
- throw MakeError(kDebugger,
+ throw %make_error(kDebugger,
'PropertyMirror cannot be serialized independently');
break;
« src/bootstrapper.cc ('K') | « src/debug/debug.js ('k') | src/js/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698