Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2222873003: [test] Split Ignition cctest expectations for variants. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Split Ignition cctest expectations for variants. R=rmcilroy@chromium.org Committed: https://crrev.com/003b6948b06e73176622802c7e79d249b7863c81 Cr-Commit-Position: refs/heads/master@{#38441}

Patch Set 1 #

Patch Set 2 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -51 lines) Patch
M test/cctest/cctest.status View 1 3 chunks +49 lines, -51 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-08 12:14:01 UTC) #3
Michael Achenbach
LGTM!
4 years, 4 months ago (2016-08-08 12:35:03 UTC) #7
rmcilroy
Lgtm, thanks!
4 years, 4 months ago (2016-08-08 12:49:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222873003/20001
4 years, 4 months ago (2016-08-08 12:56:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-08 12:57:55 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 13:00:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/003b6948b06e73176622802c7e79d249b7863c81
Cr-Commit-Position: refs/heads/master@{#38441}

Powered by Google App Engine
This is Rietveld 408576698