Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2222873002: Encapsulate GrReducedClip result in class members (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Encapsulate GrReducedClip result in class members Updates GrReducedClip to store its result in class members instead of various pointer arguments. This helps clean up calling code and will make it easier to reduce the clip higher in the stack. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222873002 Committed: https://skia.googlesource.com/skia/+/77f2fae49ec969f0771921f1c1886c12289c7bfe

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -322 lines) Patch
M include/gpu/GrClip.h View 2 chunks +12 lines, -12 lines 1 comment Download
M src/gpu/GrClipStackClip.h View 1 chunk +5 lines, -14 lines 0 comments Download
M src/gpu/GrClipStackClip.cpp View 24 chunks +61 lines, -92 lines 0 comments Download
M src/gpu/GrReducedClip.h View 2 chunks +44 lines, -24 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 18 chunks +64 lines, -57 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +2 lines, -15 lines 0 comments Download
M tests/ClipStackTest.cpp View 9 chunks +60 lines, -108 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
csmartdalton
https://codereview.chromium.org/2222873002/diff/1/include/gpu/GrClip.h File include/gpu/GrClip.h (right): https://codereview.chromium.org/2222873002/diff/1/include/gpu/GrClip.h#newcode153 include/gpu/GrClip.h:153: outerClipBounds.fBottom <= queryBounds.fTop + kBoundsTolerance; Switching to <= and ...
4 years, 4 months ago (2016-08-08 05:26:55 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-08-08 16:06:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222873002/1
4 years, 4 months ago (2016-08-08 16:21:17 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 16:55:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/77f2fae49ec969f0771921f1c1886c12289c7bfe

Powered by Google App Engine
This is Rietveld 408576698