third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html - Issue 2222863002: [Typed-OM] Enable getting CSSURLImageValue from stylemap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html

Issue 2222863002: [Typed-OM] Enable getting CSSURLImageValue from stylemap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CSSProperties_Image

Patch Set: Remove backgroundImage test from unsupported-properties, simplify test to get from StyleMap Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html ('K') | « third_party/WebKit/LayoutTests/typedcssom/cssURLImageValue.html ('k') | third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4	4

5 <div id="testElement"></div>	5 <div id="testElement"></div>

6 <div id="secondElement"></div>	6 <div id="secondElement"></div>

7	7

8 <script>	8 <script>

9	9

10 // This set of tests looks at properties that are not yet supported	10 // This set of tests looks at properties that are not yet supported

11 // by the typed OM. It will probably need to be updated as we start	11 // by the typed OM. It will probably need to be updated as we start

12 // supporting some of these properties.	12 // supporting some of these properties.

13	13

14 test(function() {	14 test(function() {

15 testElement.style.backgroundImage = 'url("")';

16

17 var result = testElement.styleMap.get('background-image');

18 assert_equals(result.constructor, CSSStyleValue);

19 assert_equals(result.cssText, 'url("")');

20 }, 'Unsupported property returns a base StyleValue with the correct cssText.');

21

22 test(function() {

23 testElement.style.backgroundImage = 'url("")';

24

25 secondElement.styleMap.set('background-image', testElement.styleMap.get('backg round-image'));

26

27 var result = secondElement.styleMap.get('background-image');

28 assert_equals(result.constructor, CSSStyleValue);

29 assert_equals(result.cssText, 'url("")');

30 }, 'Setting the same property using the result of getting an unknown value works ');
meade_UTC10 2016/08/12 05:23:16 Uhhh don't delete these tests, just change it to s Uhhh don't delete these tests, just change it to something else that's not supported.
31

32 test(function() {

33 testElement.style.color = 'green';	15 testElement.style.color = 'green';

34	16

35 secondElement.styleMap.set('border-left-color', testElement.styleMap.get('colo r'));	17 secondElement.styleMap.set('border-left-color', testElement.styleMap.get('colo r'));

36	18

37 var result = secondElement.styleMap.get('border-left-color');	19 var result = secondElement.styleMap.get('border-left-color');

38 assert_equals(result.constructor, CSSStyleValue);	20 assert_equals(result.constructor, CSSStyleValue);

39 assert_equals(result.cssText, 'green');	21 assert_equals(result.cssText, 'green');

40 }, 'Setting a different property using the result of getting an unknown value wo rks');	22 }, 'Setting a different property using the result of getting an unknown value wo rks');

41	23

42 </script>	24 </script>

OLD	NEW