Add per-section clearing and dismissed suggestions to snippets-internals

components/ntp_snippets/ntp_snippets_service.h

Index: components/ntp_snippets/ntp_snippets_service.h
diff --git a/components/ntp_snippets/ntp_snippets_service.h b/components/ntp_snippets/ntp_snippets_service.h
index de27dacdae614e0528620c4487b5e2b37f2a2cb8..741dbfe49bab276b66f83db1383271e93552d546 100644
--- a/components/ntp_snippets/ntp_snippets_service.h
+++ b/components/ntp_snippets/ntp_snippets_service.h
@@ -109,15 +109,6 @@ class NTPSnippetsService : public image_fetcher::ImageFetcherDelegate,
   void FetchSnippetsFromHosts(const std::set<std::string>& hosts,
                               bool force_request);
 
-  // Available snippets.
-  const NTPSnippet::PtrVector& snippets() const { return snippets_; }
-
-  // Returns the list of snippets previously dismissed by the user (that are
-  // not expired yet).
-  const NTPSnippet::PtrVector& dismissed_snippets() const {
-    return dismissed_snippets_;
-  }
-
   const NTPSnippetsFetcher* snippets_fetcher() const {
     return snippets_fetcher_.get();
   }
@@ -133,15 +124,15 @@ class NTPSnippetsService : public image_fetcher::ImageFetcherDelegate,
   void RescheduleFetching();
 
   // ContentSuggestionsProvider implementation
-  // TODO(pke): At some point reorder the implementations in the .cc file
-  // accordingly.

[Marc Treib, 2016/08/08 13:52:09]

Might've been nice to do that in a separate CL ;P

[Philipp Keck, 2016/08/08 14:15:09]

Acknowledged.

   std::vector<Category> GetProvidedCategories() override;
   CategoryStatus GetCategoryStatus(Category category) override;
   void DismissSuggestion(const std::string& suggestion_id) override;
   void FetchSuggestionImage(const std::string& suggestion_id,
                             const ImageFetchedCallback& callback) override;
-  void ClearCachedSuggestionsForDebugging() override;
-  void ClearDismissedSuggestionsForDebugging() override;
+  void ClearCachedSuggestionsForDebugging(Category category) override;
+  std::vector<ContentSuggestion> GetDismissedSuggestionsForDebugging(
+      Category category) override;
+  void ClearDismissedSuggestionsForDebugging(Category category) override;
 
   // Returns the lists of suggestion hosts the snippets are restricted to.
   std::set<std::string> GetSuggestionsHosts() const;
@@ -149,6 +140,11 @@ class NTPSnippetsService : public image_fetcher::ImageFetcherDelegate,
   // Returns the maximum number of snippets that will be shown at once.
   static int GetMaxSnippetCountForTesting();
 
+  // Available snippets, only for unit tests.
+  const NTPSnippet::PtrVector& GetSnippetsForTesting() const {
+    return snippets_;
+  }
+
  private:
   friend class NTPSnippetsServiceTest;
   FRIEND_TEST_ALL_PREFIXES(NTPSnippetsServiceTest, StatusChanges);