Add per-section clearing and dismissed suggestions to snippets-internals

Add per-section clearing and dismissed suggestions to snippets-internals

Add new ClearCachedSuggestionsForDebugging,
GetDismissedSuggestionsForDebugging and
ClearDismissedSuggestionsForDebugging methods to the
ContentSuggestionsProvider. Implement these methods in all existing
providers. Adjust the unit tests.

Call those methods from snippets-internals, build new internals UI for
viewing dismissed suggestions and clearing suggestions per category.
Remove now unused NTPSnippetsService-related things.

BUG=619560
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b
Cr-Commit-Position: refs/heads/master@{#410360}

[Philipp Keck, 2016-08-08 12:34:52]

Description was changed from

==========
Add per-section clearing and dismissed suggestions to snippets-internals

Add new ClearCachedSuggestionsForDebugging,
GetDismissedSuggestionsForDebugging and
ClearDismissedSuggestionsForDebugging methods to the
ContentSuggestionsProvider. Implement these methods in all existing
providers. Adjust the unit tests.

Call those methods from snippets-internals, build new internals UI for
viewing dismissed suggestions and clearing suggestions per category.
Remove now unused NTPSnippetsService-related things.

BUG=619560
==========

to

==========
Add per-section clearing and dismissed suggestions to snippets-internals

Add new ClearCachedSuggestionsForDebugging,
GetDismissedSuggestionsForDebugging and
ClearDismissedSuggestionsForDebugging methods to the
ContentSuggestionsProvider. Implement these methods in all existing
providers. Adjust the unit tests.

Call those methods from snippets-internals, build new internals UI for
viewing dismissed suggestions and clearing suggestions per category.
Remove now unused NTPSnippetsService-related things.

BUG=619560
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Philipp Keck, 2016-08-08 12:35:30]

pke@google.com changed reviewers:
+ bauerb@chromium.org, treib@chromium.org

[Philipp Keck, 2016-08-08 12:35:30]

PTAL

[Bernhard Bauer, 2016-08-08 13:27:02]

lgtm

[Philipp Keck, 2016-08-08 13:36:46]

On 2016/08/08 13:27:02, Bernhard Bauer wrote:
> lgtm

Thank you for reviewing.

I reordered the methods in snippets_internals_message_handler.cc to match the .h
file and removed two unused declarations in the .h file.

[Marc Treib, 2016-08-08 13:52:09]

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_provider.h (right):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_provider.h:98: // |category|
nit: messed up line break

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:85: for (auto&
category_provider_pair : providers_by_category_) {
const auto&

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:98:
suggestions_by_category_[category] = std::vector<ContentSuggestion>();
.clear()
?

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.h (left):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.h:137: // accordingly.
Might've been nice to do that in a separate CL ;P

[Philipp Keck, 2016-08-08 14:15:09]

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_provider.h (right):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_provider.h:98: // |category|
On 2016/08/08 13:52:09, Marc Treib wrote:
> nit: messed up line break

Done.

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
File components/ntp_snippets/content_suggestions_service.cc (right):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:85: for (auto&
category_provider_pair : providers_by_category_) {
On 2016/08/08 13:52:09, Marc Treib wrote:
> const auto&

Done.

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/con...
components/ntp_snippets/content_suggestions_service.cc:98:
suggestions_by_category_[category] = std::vector<ContentSuggestion>();
On 2016/08/08 13:52:09, Marc Treib wrote:
> .clear()
> ?

Done.

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service.h (left):

https://codereview.chromium.org/2222853004/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service.h:137: // accordingly.
On 2016/08/08 13:52:09, Marc Treib wrote:
> Might've been nice to do that in a separate CL ;P

Acknowledged.

[Marc Treib, 2016-08-08 14:16:17]

Ah, also LGTM. Meant to say that before but forgot

[Philipp Keck, 2016-08-08 14:20:57]

The CQ bit was checked by pke@google.com

[Philipp Keck, 2016-08-08 14:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2222853004/#ps40001
(title: "Marc's comments")

[commit-bot: I haz the power, 2016-08-08 14:21:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 15:18:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 15:20:55]

Description was changed from

==========
Add per-section clearing and dismissed suggestions to snippets-internals

Add new ClearCachedSuggestionsForDebugging,
GetDismissedSuggestionsForDebugging and
ClearDismissedSuggestionsForDebugging methods to the
ContentSuggestionsProvider. Implement these methods in all existing
providers. Adjust the unit tests.

Call those methods from snippets-internals, build new internals UI for
viewing dismissed suggestions and clearing suggestions per category.
Remove now unused NTPSnippetsService-related things.

BUG=619560
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add per-section clearing and dismissed suggestions to snippets-internals

Add new ClearCachedSuggestionsForDebugging,
GetDismissedSuggestionsForDebugging and
ClearDismissedSuggestionsForDebugging methods to the
ContentSuggestionsProvider. Implement these methods in all existing
providers. Adjust the unit tests.

Call those methods from snippets-internals, build new internals UI for
viewing dismissed suggestions and clearing suggestions per category.
Remove now unused NTPSnippetsService-related things.

BUG=619560
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b
Cr-Commit-Position: refs/heads/master@{#410360}
==========

[commit-bot: I haz the power, 2016-08-08 15:20:56]

Patchset 3 (id:??) landed as
https://crrev.com/17361590f84745a69e0373e6482184e3bada6c3b
Cr-Commit-Position: refs/heads/master@{#410360}

[jbudorick, 2016-08-08 15:48:27]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2223963002/ by jbudorick@chromium.org.

The reason for reverting is: Appears to have broken compilation on Android
Builder:
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds....

[anthonyvd, 2016-08-08 15:48:34]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2225753003/ by anthonyvd@chromium.org.

The reason for reverting is: Reverting this CL because it breaks the following
bot:
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds....

[findit-for-me, 2016-08-08 15:57:04]

FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 410360 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...