Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 222283002: Do not generate LDummyUse instruction for HCapturedObject (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Do not generate LDummyUse instruction for HCapturedObject LDummyUse confuses the register allocator (since there is no definition for the use). R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-captured-object-no-dummy-use.js View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 8 months ago (2014-04-02 15:02:20 UTC) #1
Michael Starzinger
LGTM.
6 years, 8 months ago (2014-04-02 15:07:12 UTC) #2
Jarin
6 years, 8 months ago (2014-04-03 07:35:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698