Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2222823002: Rust: Add validation support to code generator (Closed)

Created:
4 years, 4 months ago by mknyszek
Modified:
4 years, 4 months ago
Base URL:
git@github.com:domokit/mojo.git@decoding-test
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rust: Add validation support to code generator Adds validation checks into the generated code for decoding. R=eholk@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8d4330a624a08a873497e03390990a03e2f6fb24

Patch Set 1 #

Patch Set 2 : Fail loudly if we see a fixed array size >32 (blame the Rust type system) #

Patch Set 3 : Propagate fixed name mangling #

Patch Set 4 : Propagate changes for fixed array unboxing #

Patch Set 5 : Propagate fix for mangling #

Patch Set 6 : Add sha1 for binary uploaded to GCS #

Patch Set 7 : Double check before land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -31 lines) Patch
A mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/rust.sha1 View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M mojom/generators/rust/rustgen/type_translation.go View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M mojom/generators/rust/templates/interface.tmpl.go View 1 2 3 2 chunks +30 lines, -10 lines 0 comments Download
M mojom/generators/rust/templates/source.tmpl.go View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M mojom/generators/rust/templates/struct.tmpl.go View 1 2 3 4 1 chunk +16 lines, -10 lines 0 comments Download
M mojom/generators/rust/templates/union.tmpl.go View 1 2 3 1 chunk +15 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mknyszek
4 years, 4 months ago (2016-08-08 21:15:25 UTC) #2
Eric Holk
lgtm
4 years, 4 months ago (2016-08-08 21:19:53 UTC) #3
mknyszek
4 years, 4 months ago (2016-08-11 07:51:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
8d4330a624a08a873497e03390990a03e2f6fb24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698