Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2222813002: Remove the use of WebRange in ContentDetector. (Closed)

Created:
4 years, 4 months ago by dglazkov
Modified:
4 years, 4 months ago
Reviewers:
Ted C, esprehn, qinmin
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of WebRange in ContentDetector. The WebRange is populated, but nothing actually uses it. Also removed the ContentDetector::Result struct, which was no longer necessary. Also cleaned up the now-unnecessary plumbing in WebSurroundingText. R=esprehn BUG= Committed: https://crrev.com/0d073cb7d8e7a3b6d3f09afe957341a7e2381e31 Cr-Commit-Position: refs/heads/master@{#410284}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Patch Set 3 : Maybe now fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -93 lines) Patch
M content/renderer/android/content_detector.h View 1 3 chunks +6 lines, -21 lines 0 comments Download
M content/renderer/android/content_detector.cc View 1 2 chunks +15 lines, -37 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebSurroundingText.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
dglazkov
Fix compile.
4 years, 4 months ago (2016-08-07 05:12:44 UTC) #5
dglazkov
Maybe now fix compile.
4 years, 4 months ago (2016-08-07 15:14:45 UTC) #10
dglazkov
PTAL.
4 years, 4 months ago (2016-08-07 16:38:15 UTC) #14
esprehn
lgtm
4 years, 4 months ago (2016-08-07 19:43:44 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222813002/40001
4 years, 4 months ago (2016-08-07 19:43:53 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-07 19:47:10 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 19:49:09 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d073cb7d8e7a3b6d3f09afe957341a7e2381e31
Cr-Commit-Position: refs/heads/master@{#410284}

Powered by Google App Engine
This is Rietveld 408576698