Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Issue 2222783002: Avoid caching resources for volatile bitmap shaders (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid caching resources for volatile bitmap shaders SkBitmapProvider::isVolatile() treats all SkImages as non-volatile, which is not what we want for temp SkImage wrappers of volatile bitmaps. R=reed@google.com BUG=chromium:633941 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222783002 Committed: https://skia.googlesource.com/skia/+/5d2befe0062c7c8dfc8760d3b3c02846988e9a4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkBitmapProvider.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
f(malita)
4 years, 4 months ago (2016-08-06 18:32:23 UTC) #6
reed1
lgtm
4 years, 4 months ago (2016-08-08 13:42:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222783002/1
4 years, 4 months ago (2016-08-08 13:49:47 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 14:08:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5d2befe0062c7c8dfc8760d3b3c02846988e9a4e

Powered by Google App Engine
This is Rietveld 408576698