Avoid calling into the ContentBrowserClient interface from ResourceDispatcherHostImpl to determine …

chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_content_browser_client_extensions_part.h"
 
 #include <stddef.h>
 
 #include <set>
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/extension_webkit_preferences.h"
 #include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_io_data.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/renderer_host/chrome_extension_message_filter.h"
 #include "chrome/browser/sync_file_system/local/sync_file_system_backend.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_process_policy.h"
 #include "components/guest_view/browser/guest_view_message_filter.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/browser_url_handler.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/resource_dispatcher_host.h"
+#include "content/public/browser/resource_dispatcher_host_interceptor.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/vpn_service_proxy.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "extensions/browser/api/web_request/web_request_api.h"
 #include "extensions/browser/api/web_request/web_request_api_helpers.h"
+#include "extensions/browser/bad_message.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_message_filter.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_service_worker_message_filter.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/guest_view/extensions_guest_view_message_filter.h"
 #include "extensions/browser/guest_view/web_view/web_view_renderer_state.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/browser/io_thread_extension_message_filter.h"
 #include "extensions/browser/view_type_utils.h"
@@ skipping 74 matching lines @@
       return PRIV_ISOLATED;
     if (extension && extension->is_hosted_app())
       return PRIV_HOSTED;
   }
 
   return PRIV_EXTENSION;
 }
 
 }  // namespace
 
+// Registers a HTTP origin header interceptor on the ResourceDispatcherHost
+// for the chrome extension scheme. On getting invoked it invokes the
+// |callback in the OnHttpHeaderReceived function with success or failure
+// based on whether the extension origin is valid. For more information on
+// how we determine whether the origins are valid, please see the
+// ChromeContentBrowserClientExtensionsPart::IsIllegalOrigin() function.
+class ChromeExtensionOriginInterceptor
+    : public content::ResourceDispatcherHostInterceptor {
+ public:
+  ChromeExtensionOriginInterceptor() {
+    content::ResourceDispatcherHost::Get()->RegisterInterceptor(
+        "Origin", kExtensionScheme, this);
+  }
+
+  ~ChromeExtensionOriginInterceptor() override {
+    content::ResourceDispatcherHost::Get()->UnregisterInterceptor(
+        "Origin", this);
+  }
+
+  void OnHttpHeaderReceived(const std::string& header,
+                            const std::string& value,
+                            int child_id,
+                            content::ResourceContext* resource_context,
+                            OnHeaderProcessedCallback callback) override {
+    DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+    GURL origin(value);
+    DCHECK(origin.SchemeIs(extensions::kExtensionScheme));
+
+    if (ChromeContentBrowserClientExtensionsPart::IsIllegalOrigin(
+            resource_context, child_id, origin)) {
+      callback.Run(false, bad_message::INVALID_ORIGIN);
+    } else {
+      callback.Run(true, 0);
+    }
+  }
+};
+
 ChromeContentBrowserClientExtensionsPart::
     ChromeContentBrowserClientExtensionsPart() {
 }
 
 ChromeContentBrowserClientExtensionsPart::
     ~ChromeContentBrowserClientExtensionsPart() {
 }
 
 // static
 GURL ChromeContentBrowserClientExtensionsPart::GetEffectiveURL(
@@ skipping 129 matching lines @@
            ->Contains(new_extension->id(), process_host->GetID())) {
     return false;
   }
   return true;
 }
 
 bool ChromeContentBrowserClientExtensionsPart::IsIllegalOrigin(
     content::ResourceContext* resource_context,
     int child_process_id,
     const GURL& origin) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);

[jam, 2016/08/09 01:36:24]

no need to have this method anymore in this class, and it can just move the
callback above

[ananta, 2016/08/09 05:47:47]

Done.

 
   // Consider non-extension URLs safe; they will be checked elsewhere.
   if (!origin.SchemeIs(kExtensionScheme))
     return false;
 
   // If there is no extension installed for the URL, it couldn't have committed.
   // (If the extension was recently uninstalled, the tab would have closed.)
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
   InfoMap* extension_info_map = io_data->GetExtensionInfoMap();
   const Extension* extension =
@@ skipping 365 matching lines @@
 #if defined(ENABLE_WEBRTC)
     command_line->AppendSwitch(::switches::kEnableWebRtcHWH264Encoding);
 #endif
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(
             switches::kEnableMojoSerialService)) {
       command_line->AppendSwitch(switches::kEnableMojoSerialService);
     }
   }
 }
 
+void ChromeContentBrowserClientExtensionsPart::
+     ResourceDispatcherHostCreated() {
+  extension_origin_interceptor_.reset(new ChromeExtensionOriginInterceptor);
+}
+
 }  // namespace extensions