Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2222683002: Use SparseBooleanArray to get rid of lint warning. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 4 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SparseBooleanArray to get rid of lint warning. The use of SparseArray causes a UseSparseArrays lint warning. BUG=635179 Committed: https://crrev.com/5cefdd51a8a172292fbae98ef5d9efbe4563d4d5 Cr-Commit-Position: refs/heads/master@{#410347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
estevenson
ptal twellington, it seems performance differences would be negligible between the two structures. If this ...
4 years, 4 months ago (2016-08-05 23:07:40 UTC) #2
Theresa
This lgtm, thank you!
4 years, 4 months ago (2016-08-05 23:09:50 UTC) #3
estevenson
4 years, 4 months ago (2016-08-05 23:24:09 UTC) #5
Ted C
lgtm
4 years, 4 months ago (2016-08-06 00:25:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222683002/1
4 years, 4 months ago (2016-08-08 13:36:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 14:15:06 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 14:18:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cefdd51a8a172292fbae98ef5d9efbe4563d4d5
Cr-Commit-Position: refs/heads/master@{#410347}

Powered by Google App Engine
This is Rietveld 408576698