Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/hydrogen-store-elimination.cc

Issue 222263002: Fix approximation of CanDeoptimize() and other small store elimination fixes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/lithium-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 if (instr->CanDeoptimize()) { 122 if (instr->CanDeoptimize()) {
123 TRACE(("-- Observed stores at I%d (might deoptimize)\n", instr->id())); 123 TRACE(("-- Observed stores at I%d (might deoptimize)\n", instr->id()));
124 unobserved_.Rewind(0); 124 unobserved_.Rewind(0);
125 return; 125 return;
126 } 126 }
127 if (instr->CheckChangesFlag(kNewSpacePromotion)) { 127 if (instr->CheckChangesFlag(kNewSpacePromotion)) {
128 TRACE(("-- Observed stores at I%d (might GC)\n", instr->id())); 128 TRACE(("-- Observed stores at I%d (might GC)\n", instr->id()));
129 unobserved_.Rewind(0); 129 unobserved_.Rewind(0);
130 return; 130 return;
131 } 131 }
132 if (instr->ChangesFlags().ContainsAnyOf(flags)) { 132 if (instr->DependsOnFlags().ContainsAnyOf(flags)) {
133 TRACE(("-- Observed stores at I%d (GVN flags)\n", instr->id())); 133 TRACE(("-- Observed stores at I%d (GVN flags)\n", instr->id()));
134 unobserved_.Rewind(0); 134 unobserved_.Rewind(0);
135 return; 135 return;
136 } 136 }
137 } 137 }
138 138
139 } } // namespace v8::internal 139 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/lithium-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698