Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js

Issue 2222583002: Lock screen pin keyboard ui upgrades. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fix for closure. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js
index 9b9ba5dad8b5dc2ba8c528ddea38566061751d5e..b35fcaa44403b899e4b012b55563ceba8baa7b2a 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js
@@ -127,12 +127,12 @@ Polymer({
},
/**
- * Changes the color of the submit button if PIN is ready.
+ * Disables the submit and backspace button if nothing is entered.
* @param {string} value
* @private
*/
- getSubmitClass_: function(value) {
- return value.length > 0 ? 'ready-background' : '';
+ hasInput_: function(value) {
+ return value.length > 0;
},
/**
@@ -160,7 +160,7 @@ Polymer({
* @param {string} password
* @private
*/
- getInputClass_: function(password) {
+ isInputRtl_: function(password) {
// +password will convert a string to a number or to NaN if that's not
// possible. Number.isInteger will verify the value is not a NaN and that it
// does not contain decimals.
@@ -169,16 +169,6 @@ Polymer({
// Since we still support users entering their passwords through the PIN
// keyboard, we swap the input box to rtl when we think it is a password
// (just numbers), if the document direction is rtl.
- var enableRtl = (document.dir == 'rtl') && !Number.isInteger(+password);
- return enableRtl ? 'input-non-pin' : '';
+ return (document.dir == 'rtl') && !Number.isInteger(+password);
},
-
- /**
- * Computes if the submit button is visible.
- * @param {boolean} submitEnabled
- * @private
- */
- getSubmitHiddenClass_: function(submitEnabled) {
- return submitEnabled ? '' : 'submit-button-hidden';
- }
});
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | ui/login/account_picker/user_pod_row.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698