Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4950)

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Issue 2222583002: Lock screen pin keyboard ui upgrades. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 6 errors. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.js
diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
index a3985a55711829ab38557e69f1cde0a838b5b418..d60e0e82aaca5aa788ceb0027ca9c8ca54b49077 100644
--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
@@ -44,17 +44,6 @@ Polymer({
initialPin_: String,
/**
- * The actual problem message to display.
- * @private
- */
- problemMessage_: String,
-
- /**
- * The type of problem class to show (warning or error).
- */
- problemClass_: String,
-
- /**
* Should the step-specific submit button be displayed?
* @private
*/
@@ -88,6 +77,14 @@ Polymer({
},
/**
+ * Gets the pin keyboard element.
+ * @type {!HTMLDivElement}
+ */
+ get pinKeyboard() {
+ return this.$$('#pinKeyboard');
+ },
+
+ /**
* Resets the element to the initial state.
* @private
*/
@@ -157,15 +154,13 @@ Polymer({
* @param {string} problemClass
*/
showProblem_: function(messageId, problemClass) {
- this.problemMessage_ = this.i18n(messageId);
- this.problemClass_ = problemClass;
+ this.pinKeyboard.setProblem(this.i18n(messageId), true /*isError*/);
jdufault 2016/08/24 01:20:18 Refactor the callers of showProblem_ to also use t
sammiequon 2016/08/25 23:50:02 No more problem message.
this.updateStyles();
},
/** @private */
hideProblem_: function() {
- this.problemMessage_ = '';
- this.problemClass_ = '';
+ this.pinKeyboard.setProblem('', true /*isError*/);
jdufault 2016/08/24 01:20:18 Add a clearProblem method?
sammiequon 2016/08/25 23:50:02 No more problem message.
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698