chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc - Issue 2222583002: Lock screen pin keyboard ui upgrades.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 2222583002: Lock screen pin keyboard ui upgrades. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed patch set 3 errors. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

index 10bfe44c76e23f9319811f26439e9e9f946bcc2c..c4bb6a5a4944dbca294d7a4cd6f1cb4152b60ccc 100644

--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

@@ -378,6 +378,7 @@ void SigninScreenHandler::DeclareLocalizedValues(

builder->Add("pinKeyboardPlaceholderPinPassword",

IDS_PIN_KEYBOARD_HINT_TEXT_PIN_PASSWORD);

builder->Add("pinKeyboardClear", IDS_PIN_KEYBOARD_CLEAR);

+ builder->Add("pinKeyboardErrorMessage", IDS_PIN_KEYBOARD_ERROR_MESSAGE);

builder->Add("signingIn", IDS_LOGIN_POD_SIGNING_IN);

builder->Add("podMenuButtonAccessibleName",

IDS_LOGIN_POD_MENU_BUTTON_ACCESSIBLE_NAME);