Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/renderer/loadtimes_extension_bindings.cc

Issue 2222573003: Add use counter for chrome.loadTimes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/loadtimes_extension_bindings.cc
diff --git a/chrome/renderer/loadtimes_extension_bindings.cc b/chrome/renderer/loadtimes_extension_bindings.cc
index 61d54a9fabfa6c0a1889c8fd472c021831e7cdc1..fa2de3141df7e4b876b0b31f2ba2668fe7712724 100644
--- a/chrome/renderer/loadtimes_extension_bindings.cc
+++ b/chrome/renderer/loadtimes_extension_bindings.cc
@@ -109,7 +109,11 @@ class LoadTimesExtensionWrapper : public v8::Extension {
static void LoadtimesGetter(
v8::Local<v8::Name> name,
const v8::PropertyCallbackInfo<v8::Value>& info) {
- // TODO(panicker): Add Usage counter.
+ WebLocalFrame* frame = WebLocalFrame::frameForCurrentContext();
+ if (frame) {
esprehn 2016/08/05 20:57:36 I'd usually write: if (WebLocalFrame* frame = Web
panicker 2016/08/05 23:06:14 Sure, updated.
+ frame->usageCountChromeLoadtimes(blink::WebString::fromUTF8(
+ *v8::String::Utf8Value(name)));
+ }
info.GetReturnValue().Set(info.Data());
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/core/frame/UseCounter.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698