Removed invalid thread DCHECKs in rtc_peer_connection_handler.cc

content/renderer/media/rtc_peer_connection_handler.cc

Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index 37b9d05cf8ecaee67b048bbefe03ff8a552d94b4..16ba6a0f4c5d033a70c113bbe1f17e186fc3807e 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -369,7 +369,9 @@ class CreateSessionDescriptionRequest
   void OnSuccess(webrtc::SessionDescriptionInterface* desc) override {

[perkj_chrome, 2016/08/15 05:37:57]

webrtc::SessionDescriptionInterface* desc should have been const
scoped_refptr<webrtc::SessionDescriptionInterface>& desc instead to make this
more clear.
But I think this was actually correct from the beginning. 
Base::Bind will treat * desc  as a ref counted object unless you use
base::Unretained.

[hbos_chromium, 2016/08/15 14:16:55]

Oh, back to the drawing board.

[hbos_chromium, 2016/08/16 13:43:51]

The template magic of base::Bind is beyond me, but I did some printf debugging.

At main_thread_->PostTask, if I pass |this| both AddRef and Release occurs
before we return. The Release is unexpected. If I pass
|scoped_refptr<CreateSessionDescriptionRequest>(this)| AddRef occurs but no
Release, as it should be.

[hbos_chromium, 2016/08/17 09:51:15]

Nevermind. The different printfs can be explained by races between threads or
whatnot.

     if (!main_thread_->BelongsToCurrentThread()) {
       main_thread_->PostTask(FROM_HERE,
-          base::Bind(&CreateSessionDescriptionRequest::OnSuccess, this, desc));
+          base::Bind(&CreateSessionDescriptionRequest::OnSuccess,
+                     scoped_refptr<CreateSessionDescriptionRequest>(this),
+                     desc));
       return;
     }
 
@@ -381,7 +383,9 @@ class CreateSessionDescriptionRequest
   void OnFailure(const std::string& error) override {
     if (!main_thread_->BelongsToCurrentThread()) {
       main_thread_->PostTask(FROM_HERE,
-          base::Bind(&CreateSessionDescriptionRequest::OnFailure, this, error));
+          base::Bind(&CreateSessionDescriptionRequest::OnFailure,
+                     scoped_refptr<CreateSessionDescriptionRequest>(this),
+                     error));
       return;
     }
 
@@ -421,7 +425,8 @@ class SetSessionDescriptionRequest
   void OnSuccess() override {
     if (!main_thread_->BelongsToCurrentThread()) {
       main_thread_->PostTask(FROM_HERE,
-          base::Bind(&SetSessionDescriptionRequest::OnSuccess, this));
+          base::Bind(&SetSessionDescriptionRequest::OnSuccess,
+                     scoped_refptr<SetSessionDescriptionRequest>(this)));
       return;
     }
     tracker_.TrackOnSuccess(NULL);
@@ -431,7 +436,9 @@ class SetSessionDescriptionRequest
   void OnFailure(const std::string& error) override {
     if (!main_thread_->BelongsToCurrentThread()) {
       main_thread_->PostTask(FROM_HERE,
-          base::Bind(&SetSessionDescriptionRequest::OnFailure, this, error));
+          base::Bind(&SetSessionDescriptionRequest::OnFailure,
+                     scoped_refptr<SetSessionDescriptionRequest>(this),
+                     error));
       return;
     }
     tracker_.TrackOnFailure(error);