Issue 2222523003: SkPDF/SkAdvancedTypefaceMetrics: simplify ATM, PDF takes over

hal.canary

halcanary@google.com changed reviewers: + bungeman@google.com

4 years, 4 months ago (2016-08-05 20:13:55 UTC) #1

hal.canary

Description was changed from ========== SkPDF/SkAdvancedTypefaceMetrics: simplifyt ATM, PDF takes over ========== to ========== SkPDF/SkAdvancedTypefaceMetrics: ...

4 years, 4 months ago (2016-08-05 20:14:04 UTC) #3

hal.canary

The CQ bit was checked by halcanary@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-05 23:29:06 UTC) #4

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/1

4 years, 4 months ago (2016-08-05 23:29:11 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-05 23:36:29 UTC) #6

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Release-Vulkan-Trybot/builds/516)

4 years, 4 months ago (2016-08-05 23:36:30 UTC) #7

hal.canary

The CQ bit was checked by halcanary@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-06 00:04:30 UTC) #9

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/40001

4 years, 4 months ago (2016-08-06 00:04:35 UTC) #10

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-06 00:22:09 UTC) #11

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 4 months ago (2016-08-06 00:22:10 UTC) #12

hal.canary

The CQ bit was checked by halcanary@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-07 12:22:50 UTC) #14

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/60001

4 years, 4 months ago (2016-08-07 12:22:55 UTC) #15

hal.canary

I went ahead and deleted dead code as part of this CL.

4 years, 4 months ago (2016-08-07 12:23:12 UTC) #16

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-07 12:42:03 UTC) #17

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 4 months ago (2016-08-07 12:42:04 UTC) #18

bungeman-skia

lgtm with one nit. https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp#newcode1284 src/pdf/SkPDFFont.cpp:1284: glyphIDs->begin(), nit: indentation

4 years, 4 months ago (2016-08-08 14:06:09 UTC) #19

bungeman-skia

The CQ bit was checked by bungeman@google.com to run a CQ dry run

4 years, 4 months ago (2016-08-08 14:06:16 UTC) #20

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/60001

4 years, 4 months ago (2016-08-08 14:06:22 UTC) #21

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-08 14:24:07 UTC) #22

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 4 months ago (2016-08-08 14:24:07 UTC) #23

hal.canary

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com Link to the ...

4 years, 4 months ago (2016-08-08 15:48:15 UTC) #26

hal.canary

https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp#newcode1284 src/pdf/SkPDFFont.cpp:1284: glyphIDs->begin(), On 2016/08/08 14:06:09, bungeman-skia wrote: > nit: indentation ...

4 years, 4 months ago (2016-08-08 15:48:19 UTC) #27

hal.canary

https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): https://codereview.chromium.org/2222523003/diff/60001/src/pdf/SkPDFFont.cpp#newcode1284 src/pdf/SkPDFFont.cpp:1284: glyphIDs->begin(), On 2016/08/08 14:06:09, bungeman-skia wrote: > nit: indentation ...

4 years, 4 months ago (2016-08-08 15:48:19 UTC) #28

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/100001

4 years, 4 months ago (2016-08-08 15:48:28 UTC) #29

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-08 15:50:35 UTC) #30

commit-bot: I haz the power

Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12290)

4 years, 4 months ago (2016-08-08 15:50:36 UTC) #31

hal.canary

Description was changed from ========== SkPDF/SkAdvancedTypefaceMetrics: simplifyt ATM, PDF takes over GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222523003 ========== to ...

4 years, 4 months ago (2016-08-08 15:54:07 UTC) #32

hal.canary

Description was changed from ========== SkPDF/SkAdvancedTypefaceMetrics: simplify ATM, PDF takes over GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2222523003 ========== to ...

4 years, 4 months ago (2016-08-08 15:55:22 UTC) #33

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222523003/100001

4 years, 4 months ago (2016-08-08 15:56:59 UTC) #35

commit-bot: I haz the power

Description was changed from ========== SkPDF/SkAdvancedTypefaceMetrics: simplify ATM, PDF takes over No public API changes. ...

4 years, 4 months ago (2016-08-08 16:10:02 UTC) #36

commit-bot: I haz the power

4 years, 4 months ago (2016-08-08 16:10:04 UTC) #37

Message was sent while issue was closed.

Committed patchset #3 (id:100001) as
https://skia.googlesource.com/skia/+/8b1d32c8d017c84828ed65af38cd1f1e7075ce08

Issue 2222523003: SkPDF/SkAdvancedTypefaceMetrics: simplify ATM, PDF takes over (Closed)

Description

Patch Set 1 : 2016-08-05 (Friday) 20:03:59 EDT #

Patch Set 2 : 2016-08-07 (Sunday) 08:21:11 EDT #

Patch Set 3 : rebase and nit #

Messages