Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2222503003:
No need to stop the one shot timer once the timer fired. (Closed)
|
Created:
4 years, 4 months ago by pals Modified:
4 years, 4 months ago Reviewers:
please use gerrit instead CC:
chromium-reviews, blink-reviews, haraken Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionNo need to stop the one shot timer once the timer fired.
BUG=632708
TEST=None (No behavior change)
Committed: https://crrev.com/8ba9003c3da8ef31cf116ad1358e9fd32557f3be
Cr-Commit-Position: refs/heads/master@{#410561}
Patch Set 1 : Fixed test failures #
Total comments: 2
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by sanjoy.pal@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sanjoy.pal@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) ========== to ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) ==========
sanjoy.pal@samsung.com changed reviewers: + rouslan@chromium.org
PTAL.
https://codereview.chromium.org/2222503003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2222503003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:28: #include "public/platform/WebTraceLocation.h" Why was this include added?
Ptal. https://codereview.chromium.org/2222503003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2222503003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:28: #include "public/platform/WebTraceLocation.h" On 2016/08/08 16:35:58, rouslan wrote: > Why was this include added? Its for the BLINK_FROM_HERE.
The CQ bit was checked by rouslan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) ========== to ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) ========== to ========== No need to stop the one shot timer once the timer fired. BUG=632708 TEST=None (No behavior change) Committed: https://crrev.com/8ba9003c3da8ef31cf116ad1358e9fd32557f3be Cr-Commit-Position: refs/heads/master@{#410561} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8ba9003c3da8ef31cf116ad1358e9fd32557f3be Cr-Commit-Position: refs/heads/master@{#410561} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
