Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2222503002: Revert of Remove redundant ParseInfo::scope_. (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
neis, adamk, marja
CC:
v8-reviews_googlegroups.com, marja
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove redundant ParseInfo::scope_. (patchset #4 id:60001 of https://codereview.chromium.org/2216563003/ ) Reason for revert: Reverting to revert https://codereview.chromium.org/2209573002 Original issue's description: > Remove redundant ParseInfo::scope_. > > This was always set to the literal's scope. > > (Additional change: mark getters as const.) > > R=adamk@chromium.org > BUG= > > Committed: https://crrev.com/23ea0782977ed3a4dd113462af9ecbfd6ff0ce94 > Cr-Commit-Position: refs/heads/master@{#38372} TBR=adamk@chromium.org,marja@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/85e41a88e58821aec10d97a5a30c4dfe3afb65c9 Cr-Commit-Position: refs/heads/master@{#38379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M src/ast/scopes.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 7 chunks +24 lines, -26 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Achenbach
Created Revert of Remove redundant ParseInfo::scope_.
4 years, 4 months ago (2016-08-05 12:20:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222503002/1
4 years, 4 months ago (2016-08-05 12:20:33 UTC) #3
commit-bot: I haz the power
Failed to apply patch for src/parsing/parser.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-08-05 12:20:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222503002/1
4 years, 4 months ago (2016-08-05 12:34:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:35:10 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:37:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85e41a88e58821aec10d97a5a30c4dfe3afb65c9
Cr-Commit-Position: refs/heads/master@{#38379}

Powered by Google App Engine
This is Rietveld 408576698