[ast] Remove obsolete DECLARE_NODE_TYPE macro.

[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=

Committed: https://crrev.com/642c184fb43535a4993dafddb63f7f0624ad39da
Cr-Commit-Position: refs/heads/master@{#38421}

[neis, 2016-08-05 15:18:57]

Description was changed from

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=
==========

to

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=
==========

[neis, 2016-08-05 15:18:57]

neis@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2016-08-05 21:52:36]

lgtm besides style nit regarding ordering

https://codereview.chromium.org/2222473002/diff/1/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2222473002/diff/1/src/ast/ast.h#newcode431
src/ast/ast.h:431: friend class AstNodeFactory;
I think we generally put friend declarations in the "private" section (which
keeps the "public" section more useful as API documentation).

[neis, 2016-08-08 08:48:21]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-08 08:48:22]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2222473002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-08-08 08:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-08-08 08:49:34]

On 2016/08/05 21:52:36, adamk wrote:
> lgtm besides style nit regarding ordering
> 
> https://codereview.chromium.org/2222473002/diff/1/src/ast/ast.h
> File src/ast/ast.h (right):
> 
> https://codereview.chromium.org/2222473002/diff/1/src/ast/ast.h#newcode431
> src/ast/ast.h:431: friend class AstNodeFactory;
> I think we generally put friend declarations in the "private" section (which
> keeps the "public" section more useful as API documentation).

Ok, I did that. Also made 'protected' stuff 'private' where possible and removed
the friend declaration from super classes.

[commit-bot: I haz the power, 2016-08-08 09:12:04]

Description was changed from

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=
==========

to

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-08-08 09:12:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 09:15:17]

Description was changed from

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=
==========

to

==========
[ast] Remove obsolete DECLARE_NODE_TYPE macro.

R=verwaest@chromium.org
BUG=

Committed: https://crrev.com/642c184fb43535a4993dafddb63f7f0624ad39da
Cr-Commit-Position: refs/heads/master@{#38421}
==========

[commit-bot: I haz the power, 2016-08-08 09:15:18]

Patchset 2 (id:??) landed as
https://crrev.com/642c184fb43535a4993dafddb63f7f0624ad39da
Cr-Commit-Position: refs/heads/master@{#38421}