Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2222453003: [system-health] Disable {load, browse}:news:washingtonpost on mobile (Closed)

Created:
4 years, 4 months ago by petrcermak
Modified:
4 years, 4 months ago
Reviewers:
nednguyen, ulan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system-health] Disable {load, browse}:news:washingtonpost on mobile Rationale: The stories are failing in system_health.memory_mobile and v8.browsing_mobile benchmarks on Android One and Nexus 5 bots. The issue was originally addressed by completely disabling system_health.memory_mobile on Android One. This patch undoes that, i.e. system_health.memory_mobile will be re-enabled on Android One. BUG=634112 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/b344b3fcb45b3ab684e395173ec4a1c4324aecdd Cr-Commit-Position: refs/heads/master@{#410072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M tools/perf/benchmarks/system_health.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 4 months ago (2016-08-05 12:35:32 UTC) #3
ulan
Thank you for preparing CL. LGTM.
4 years, 4 months ago (2016-08-05 12:37:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222453003/1
4 years, 4 months ago (2016-08-05 12:40:47 UTC) #6
nednguyen
lgtm
4 years, 4 months ago (2016-08-05 13:17:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-05 14:41:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222453003/1
4 years, 4 months ago (2016-08-05 14:46:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222453003/1
4 years, 4 months ago (2016-08-05 16:05:30 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 16:09:30 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:10:43 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b344b3fcb45b3ab684e395173ec4a1c4324aecdd
Cr-Commit-Position: refs/heads/master@{#410072}

Powered by Google App Engine
This is Rietveld 408576698